Separate CalledProcessError and FileNotFoundError exceptions #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orginal logic does not make distinction between situation when:
1. yq is missing, not installed, this problem is addressed here:
instructlab/instructlab#2796
2. when yq found a problem with the format and validation
command failed
This commit separate scenario [1] and [2]. Also improve warning
messages, allows user to re-run the yq command and help find a problem
within qna.yaml file.
Signed-off-by: Radoslaw Smigielski <[email protected]>
bjhargrave
requested changes
Dec 16, 2024
There was a problem hiding this comment.
I think any issue you see here is caused by using the incorrect yq command. See instructlab/instructlab#2796 (comment). If you use the yq python package, the line operator does not exist and you will get an error.
So a better idea might be to advise the user upon the operator error that they need to use the proper yq command, https://github.com/mikefarah/yq, and not the yq python package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orginal logic does not make distinction between situation when:
This commit separate scenario [1] and [2]. Also improve warning messages, allows user to re-run the yq command and help find a problem within qna.yaml file.