Skip to content

fix: tracing fastapi app #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

fix: tracing fastapi app #805

merged 1 commit into from
Oct 9, 2025

Conversation

minatooni
Copy link
Contributor

@minatooni minatooni commented Sep 26, 2025 •
edited
Loading

close #804

Here, FastAPI accepts Sequence and the current implementation of InstanaASGIMiddleware insert does not cover tuple
https://github.com/fastapi/fastapi/blob/450a334253b1426aab08b4dea17b16ba8b4c098c/fastapi/applications.py#L472

Are there any document that describes how to run tests? This is super small change tho

@minatooni minatooni force-pushed the fix/tracing-fastapi-app branch from 7fcec7e to 9e8282a Compare September 26, 2025 02:52
minatooni
minatooni commented Sep 26, 2025
View reviewed changes
@minatooni
Copy link
Contributor Author

Got following error on CI test but it looks like not caused by my pr

python 3.12 kafka

  • FAILED tests/clients/kafka/test_kafka_python.py::TestKafkaPython::test_trace_kafka_python_consume - AssertionError: assert 1 == 3

python 3.13 test

  • FAILED tests/frameworks/test_grpcio.py::TestGRPCIO::test_no_root_exit_span - AssertionError: assert 1 == 0
  • FAILED tests/frameworks/test_tornado_server.py::TestTornadoServer::test_get - AssertionError: assert 2 == 3

@minatooni minatooni marked this pull request as ready for review September 26, 2025 04:10
@minatooni minatooni requested a review from a team as a code owner September 26, 2025 04:10
pvital
pvital requested changes Sep 30, 2025
View reviewed changes
@minatooni minatooni force-pushed the fix/tracing-fastapi-app branch from 9e8282a to 223455f Compare October 9, 2025 04:31
minatooni
minatooni commented Oct 9, 2025
View reviewed changes
Copy link
Contributor Author

@minatooni minatooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvital Added else statement. Could you please take a look for this pr again?

@pvital pvital force-pushed the fix/tracing-fastapi-app branch from 223455f to 971f35a Compare October 9, 2025 06:11
pvital
pvital requested changes Oct 9, 2025
View reviewed changes
@minatooni
fix: tracing fastapi app
889adf3 
Signed-off-by: minatooni <[email protected]>
@minatooni minatooni force-pushed the fix/tracing-fastapi-app branch from 65b17e0 to 889adf3 Compare October 9, 2025 06:41
pvital
pvital approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital merged commit 9183bcb into instana:main Oct 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

Assignees

@minatooni minatooni

Labels

bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot send trace with FastAPI

2 participants

@minatooni @pvital