Skip to content

Update InstanaTracer to utilize kind argument #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HonakerM
Copy link

@HonakerM HonakerM commented Jul 2, 2025

Hello,

I am working on instrumenting an application with instana and I was really confused on why the kind argument was not working for setting span kinds. I then realized it's because it's not used! This PR fixes that and automatically adds the kind if one was provided

Signed-off-by: Michael Honaker <[email protected]>
@HonakerM HonakerM requested a review from a team as a code owner July 2, 2025 15:19
@HonakerM
Copy link
Author

HonakerM commented Jul 2, 2025

CC: @GSVarsha @pvital @CagriYonca wasn't sure who I should ping for review/merge

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @HonakerM. Thank you for your PR.

We don't "use" the kind while starting the span, because we set this value following our internal table of types based on the span name during the closing stage of the span lifetime, when we create the Instana Span payload before transmiting it to the Agent. Check the RegisteredSpan class and you will see this setting.

The start_span() and the start_as_current_span() have the kind as argument because we are implementing the OpenTelemetry's Interface for the Tracer.

Your contribution is very useful, but still need a bit more work since it will be overwrited by the RegisteredSpan logic. In addition, changes in the unit tests will be necessary and more than welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants