fix: updated amqp instrumentation, adapted attributes and unittests #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CagriYonca
commented
May 21, 2025
CagriYonca
commented
- Updated aioamqp instrumentation, changed spantype from sdk to amqp.
- Adapted attributes according to the backend code.
CagriYonca
force-pushed
the
fix/aioamqp
branch
2 times, most recently
from
6eaddf5 to
0c61b0f
Compare
GSVarsha
reviewed
May 22, 2025
Signed-off-by: Cagri Yonca <[email protected]>
GSVarsha
reviewed
May 22, 2025
| @@ -26,11 +26,31 @@ async def basic_publish_with_instana( | |||
| "aioamqp-publisher", span_context=parent_context | |||
| ) as span: | |||
| try: | |||
| span.set_attribute("aioamqp.exchange", argv[0]) | |||
| return await wrapped(*argv, **kwargs) | |||
| span.set_attribute("amqp.message", argv[0]) | |||
There was a problem hiding this comment.
I couldn't find an entry for amqp.message attribute in the backend/ui-client code. Could you please confirm if we need this here?
If yes, can you decode() the message from bytes to str and then store?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.