Skip to content

fix: updated amqp instrumentation, adapted attributes and unittests #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

CagriYonca
Copy link
Contributor

  • Updated aioamqp instrumentation, changed spantype from sdk to amqp.
  • Adapted attributes according to the backend code.

@CagriYonca CagriYonca self-assigned this May 21, 2025
@CagriYonca CagriYonca requested a review from a team as a code owner May 21, 2025 09:46
@CagriYonca CagriYonca force-pushed the fix/aioamqp branch 2 times, most recently from 6eaddf5 to 0c61b0f Compare May 21, 2025 10:28
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

@CagriYonca CagriYonca force-pushed the fix/aioamqp branch 2 times, most recently from 0340981 to 804aef3 Compare June 10, 2025 14:10
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question!

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit df5f489 into main Jun 17, 2025
16 checks passed
@CagriYonca CagriYonca deleted the fix/aioamqp branch June 17, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants