Skip to content

fix: re-entrant Collector threads on musl-based systems. #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

pvital
Copy link
Member

@pvital pvital commented May 21, 2025

No description provided.

@pvital pvital self-assigned this May 21, 2025
@pvital pvital added bug wip work in progress Do not merge Depends on another PR labels May 21, 2025
@pvital pvital removed wip work in progress Do not merge Depends on another PR labels Jun 4, 2025
@pvital pvital marked this pull request as ready for review June 4, 2025 20:02
@pvital pvital requested a review from a team as a code owner June 4, 2025 20:02
pvital added 3 commits June 4, 2025 22:19
Used ruff (vscode) to:
- Black-compatible code formatting.
- fix all auto-fixable violations, like unused imports.
- isort-compatible import sorting.

Signed-off-by: Paulo Vital <[email protected]>
As the BaseCollector.background_report runs in a thread on top of a `while True` loop, it's test is impossible to capture the output.

Signed-off-by: Paulo Vital <[email protected]>
Copy link

@arjun-rajappa arjun-rajappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvital pvital merged commit 9047151 into instana:main Jun 5, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants