Reintroduce custom fetch to buildAuthenticatedFetch as an option #3952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description
This PR addresses #3810.
Add the optional
fetch
parameter back tobuildAuthenticatedFetch
options (second parameter), defaulting to globalfetch
. This is a non-breaking change.Usage:
Motivation
Custom
fetch
was removed in v2 of@inrupt/solid-client-authn-core
. ButbuildAuthenticatedFetch
is used externally as well, most notably in automated CSS authentication. While not strictly necessary for most use cases, a customfetch
option gives more flexibility (polyfills, logging, tweaking functionality, etc.) when building authenticated fetches.Checklist
core
; will add upon requestindex.ts
, if applicable. not applicableFixes #3810