Skip to content

Expose prompt option in login method #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class AuthorizationCodeWithPkceOidcHandler
// profile referenced by the WebId.
loadUserInfo: false,
code_verifier: true,
prompt: oidcLoginOptions.prompt ?? "consent",
prompt: 'prompt' in oidcLoginOptions ? oidcLoginOptions.prompt : "consent",
};
/* eslint-enable camelcase */

Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/ILoginInputOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,11 @@ export default interface ILoginInputOptions {
* secret to authenticate.
*/
refreshToken?: string;
/**
* Specify whether the Solid Identity Provider may, or may not, interact with the user (for example,
* the normal login process **_requires_** human interaction for them to enter their credentials,
* but if a user simply refreshes the current page in their browser, we'll want to log them in again
* automatically, i.e., without prompting them to manually provide their credentials again).
*/
prompt?: string;
}
7 changes: 0 additions & 7 deletions packages/core/src/login/ILoginOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ export default interface ILoginOptions extends ILoginInputOptions {
// 'bundling' into this options interface), but it wouldn't be a significant
// improvement really...
sessionId: string;
/**
* Specify whether the Solid Identity Provider may, or may not, interact with the user (for example,
* the normal login process **_requires_** human interaction for them to enter their credentials,
* but if a user simply refreshes the current page in their browser, we'll want to log them in again
* automatically, i.e., without prompting them to manually provide their credentials again).
*/
prompt?: string;
// Force the token type to be required (i.e. no longer optional).
tokenType: "DPoP" | "Bearer";

Expand Down