Skip to content

Delete jira-feedback.html #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

KyraAssaad
Copy link

No description provided.

@KyraAssaad KyraAssaad requested a review from a team as a code owner February 3, 2025 19:54
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the goal of this PR please? Are you removing the feedback mechanism that links to this popup?
image

The reference to this file will also need removing from the layout.

Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardsph
Copy link
Contributor

What is the plan for rolling this change out? It will need all docs sections re-publishing in order to remove the feedback link and since the JS SDK API docs pipelines are broken, we would need to do a search/replace in the docs repo to remove from those sections too.

@KyraAssaad
Copy link
Author

Yes, we are removing the feedback mechanism that links to this popup. We don't have capacity right now to attend to incoming feedback, and we are going to reassess the feedback mechanism we provide in another workstream.

For the rollout plan, I can take a pass at manually removing it from the JS SDK API pages. Would you be able to trigger a build for me and I can go in and do the cleanup? @edwardsph

@edwardsph
Copy link
Contributor

I think the process (after merging this PR) will be:

  • Run all the docs generation pipelines which work - that will auto update hundreds of files.
  • Identify patterns for the remaining files (probably just API docs) which contain references to ATL_JQ_PAGE_PROPS - this will identify about 100 files to be updated manually but I would suggest using a multiline regex search/replace to deal with those rather than do them individually.
  • That will lead to 1 very large PR to merge with lots of deletions
  • As soon as it is merged, the docs are published automatically

I'm happy to pick this up if you want to get a ticket scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants