feat: extensible main chain follower #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientTea
reviewed
Mar 17, 2025
| @@ -607,7 +607,7 @@ pub(crate) async fn index_exists(pool: &Pool<Postgres>, index_name: &str) -> boo | |||
| /// Sums all transfers between genesis and the first block that is produced with the feature on. | |||
| /// Used by `get_native_token_transfers` (NativeTokenDataSourceImpl). | |||
| #[cfg(feature = "native-token")] | |||
| pub(crate) async fn get_total_native_tokens_transfered( | |||
| pub async fn get_total_native_tokens_transfered( | |||
There was a problem hiding this comment.
This functionality can be accessed through the already public API: NativeTokenManagementDataSource::get_total_native_token_transfer
AmbientTea
reviewed
Mar 17, 2025
| @@ -641,7 +641,7 @@ AND block.block_no <= $4; | |||
| /// On devnet postgres it takes around 5ms to execute when querying 1000 blocks. | |||
| /// Used by `get_native_token_transfers` (NativeTokenDataSourceImpl). | |||
| #[cfg(feature = "native-token")] | |||
| pub(crate) async fn get_native_token_transfers( | |||
| pub async fn get_native_token_transfers( | |||
There was a problem hiding this comment.
This should be already covered by NativeTokenManagementDataSource::get_total_native_token_transfer already
AmbientTea
reviewed
Mar 17, 2025
| @@ -347,7 +347,7 @@ WHERE | |||
| } | |||
|
|
|||
| #[cfg(any(feature = "block-source", feature = "native-token"))] | |||
| pub(crate) async fn get_latest_block_info( | |||
| pub async fn get_latest_block_info( | |||
There was a problem hiding this comment.
This is already provided by BlockDataSourceImpl::get_latest_block_info, which is public but wasn't really intended to be. We could arrange to officially expose it
There was a problem hiding this comment.
We should - it seems more useful to expose it than to stretch BlockDataSourceImpl into a place where it doesn't make sense.
|
Closing in preference of #594. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any given partnerchain who wishes to perform custom queries, and also send custom data through mainchain follower has a difficult time progressing because of the small surface area of the main chain follower API, and the amount of dependencies in the code. Such teams may fork the entire main-chain-follower to update a few lines, but for Midnight, this is a blocker. It's an unmaintainable amount of code required for relatively small changes, and mostly consists of code that is required to sustain a general partner-chain(e.g. db-sync queries for block data), which is not the responsibility of a partner-chain implementer.
There may be an approach to provide custom queries without forking any code, but if there is such a path, it's entirely unclear. I'll argue that an approach enabled by this PR is much clearer, and provides a nice repo structure to any implementing partnerchain. E.g. for extending db_model, the repo can include their own db_model, import the partner-chains module, and can base their "extension" solely on their own query.
Checklist
changelog.mdfor affected crate