Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: ETCM-9592 Move "Ariadne" to selection crate #578

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Mar 17, 2025

Description

  • disentangles the "Ariadne" algorithm from the authority-selection-inherents crate's code and moves into the selection crate
  • adds property tests for it
  • moves substrate-aware helper functions out of the selection crate, so it can be a pure Rust crate

There's quite a lot LOC changed here, but a big chunk of it is tests and moving stuff around. Main action is between select_authorities.rs and newly added ariadne.rs, where I had to make some types generic in the moved code.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@AmbientTea AmbientTea force-pushed the move-ariadne-to-selection-crate branch from 8be1215 to bfcc4d7 Compare March 17, 2025 12:19
@AmbientTea AmbientTea changed the title change: Move "Ariadne" to selection crate change: ETCM-9592 Move "Ariadne" to selection crate Mar 17, 2025
@AmbientTea AmbientTea marked this pull request as ready for review March 17, 2025 12:20
@AmbientTea AmbientTea force-pushed the move-ariadne-to-selection-crate branch from bfcc4d7 to 83194e7 Compare March 18, 2025 06:27
@AmbientTea AmbientTea enabled auto-merge (squash) March 18, 2025 06:36
@AmbientTea AmbientTea force-pushed the move-ariadne-to-selection-crate branch from 3ed59d6 to b4bde17 Compare March 18, 2025 09:55
@AmbientTea
Copy link
Contributor Author

Successfully tested this on my local 3-node chain (upgrade from 1.5). Will merge

@AmbientTea AmbientTea force-pushed the move-ariadne-to-selection-crate branch from 451484f to d7c6502 Compare March 18, 2025 14:47
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
@AmbientTea AmbientTea force-pushed the move-ariadne-to-selection-crate branch from 806c1af to a7ccd2c Compare March 19, 2025 05:08
@AmbientTea AmbientTea merged commit 49ce6e4 into master Mar 19, 2025
24 checks passed
@AmbientTea AmbientTea deleted the move-ariadne-to-selection-crate branch March 19, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants