-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: ETCM-9592 Move "Ariadne" to selection crate #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientTea
commented
Mar 17, 2025
toolkit/primitives/authority-selection-inherents/src/filter_invalid_candidates.rs
Outdated
Show resolved
Hide resolved
AmbientTea
commented
Mar 17, 2025
toolkit/primitives/authority-selection-inherents/src/select_authorities.rs
Show resolved
Hide resolved
8be1215
to
bfcc4d7
Compare
kpinter-iohk
approved these changes
Mar 17, 2025
bfcc4d7
to
83194e7
Compare
Klapeyron
reviewed
Mar 18, 2025
LGLO
reviewed
Mar 18, 2025
LGLO
approved these changes
Mar 18, 2025
Klapeyron
reviewed
Mar 18, 2025
toolkit/primitives/authority-selection-inherents/src/filter_invalid_candidates.rs
Outdated
Show resolved
Hide resolved
3ed59d6
to
b4bde17
Compare
Klapeyron
reviewed
Mar 18, 2025
toolkit/primitives/authority-selection-inherents/src/filter_invalid_candidates.rs
Outdated
Show resolved
Hide resolved
Successfully tested this on my local 3-node chain (upgrade from 1.5). Will merge |
Klapeyron
reviewed
Mar 18, 2025
toolkit/primitives/authority-selection-inherents/src/filter_invalid_candidates.rs
Outdated
Show resolved
Hide resolved
451484f
to
d7c6502
Compare
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
806c1af
to
a7ccd2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's quite a lot LOC changed here, but a big chunk of it is tests and moving stuff around. Main action is between
select_authorities.rs
and newly addedariadne.rs
, where I had to make some types generic in the moved code.Checklist
changelog.md
for affected crate