multi-sig for d-param #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
reviewed
Mar 10, 2025
LGLO
reviewed
Mar 10, 2025
jankun4
force-pushed
the
ETCM-9518-add-multi-sig-functionality-to-the-d-parameter-commands
branch
6 times, most recently
from
5fc32fb to
1c69d26
Compare
jankun4
force-pushed
the
ETCM-9518-add-multi-sig-functionality-to-the-d-parameter-commands
branch
from
1c69d26 to
38dfd26
Compare
jankun4
force-pushed
the
ETCM-9518-add-multi-sig-functionality-to-the-d-parameter-commands
branch
from
38dfd26 to
a0c6381
Compare
LGLO
reviewed
Mar 21, 2025
| @@ -4,6 +4,8 @@ | |||
| //! The datum encodes D-parameter using VersionedGenericDatum envelope with the D-parameter being | |||
| //! `datum` field being `[num_permissioned_candidates, num_registered_candidates]`. | |||
|
|
|||
| use std::any::Any; | |||
|
|
|||
There was a problem hiding this comment.
cosmetic: please keep in one block, no new lines
| Ok(TxHash(tx_id)) | ||
| } else { | ||
| let authorities = gov_data.policy.key_hashes(); | ||
| if authorities.contains(&ctx.payment_key_hash().to_bytes().try_into().unwrap()) { |
There was a problem hiding this comment.
I would say it doesn't matter if ctx.payment_key_hash is an authority or not. Since it pays for the TX, it needs to sign it. I propose simplifying it by dropping this check and else case and dropping the key_hashes() combinator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
link
Checklist
changelog.mdfor affected crate