wip permissioned #542
Closed
wip permissioned #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
reviewed
Mar 6, 2025
| @@ -17,6 +18,8 @@ pub struct UpsertPermissionedCandidatesCmd { | |||
| payment_key_file: PaymentFilePath, | |||
| #[arg(long, short('c'))] | |||
| genesis_utxo: UtxoId, | |||
| #[arg(short, long, num_args = 1.., value_delimiter = ' ')] | |||
| governance_authority: Vec<MainchainKeyHash>, | |||
There was a problem hiding this comment.
docs are not update and this parameter doesn't have a doc string as well, but I think this one should have it
LGLO
reviewed
Mar 6, 2025
| ogmios_client, | ||
| ) | ||
| .await?, | ||
| ) | ||
| }, | ||
| }; | ||
| if let Some(tx_hash) = tx_hash_opt { | ||
| if let Some(TxHash(tx_hash)) = tx_hash_opt { | ||
| await_tx.await_tx_output(ogmios_client, UtxoId::new(tx_hash.0, 0)).await?; | ||
| } | ||
| Ok(tx_hash_opt) |
There was a problem hiding this comment.
tx_hash_opt is not an Option anymore, right?
|
I see "wip" - should it be draft? Should we review it? |
|
Superseded by #585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
link
Checklist
changelog.mdfor affected crate