Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-sig for governance commands #538

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Mar 5, 2025

Description

Adds multi-sig capabilities to governance init and update commands

link

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@LGLO
Copy link
Contributor

LGLO commented Mar 6, 2025

One general comment is that I really like how you deal with this additional layer of complexity. I was afraid that it would be much more invasive. Good job!

@jankun4 jankun4 force-pushed the ETCM-9485-add-multi-sig-functionality-to-the-governance-init-update-commands branch 8 times, most recently from 5a297ce to 14515f1 Compare March 11, 2025 16:44
@jankun4 jankun4 force-pushed the ETCM-9485-add-multi-sig-functionality-to-the-governance-init-update-commands branch from 14515f1 to 26d28f1 Compare March 18, 2025 13:06
@jankun4 jankun4 force-pushed the ETCM-9485-add-multi-sig-functionality-to-the-governance-init-update-commands branch 2 times, most recently from 7164240 to 0444615 Compare March 18, 2025 14:01
@jankun4 jankun4 force-pushed the ETCM-9485-add-multi-sig-functionality-to-the-governance-init-update-commands branch from 0444615 to 4d248ae Compare March 19, 2025 02:13
@jankun4 jankun4 merged commit 38b8258 into master Mar 19, 2025
24 checks passed
@jankun4 jankun4 deleted the ETCM-9485-add-multi-sig-functionality-to-the-governance-init-update-commands branch March 19, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants