Trace Schema Changes #202
Merged
Trace Schema Changes #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
will-break-it
commented
Feb 18, 2025
•
will-break-it
commented
- add cpu_time_s field to track total CPU time across cores
- align block event names
- separate block lifecycle actions from network actions
- separate block lifecycle actions from network actions - use shorter block type names (IB/EB/RB/VT)
SupernaviX
approved these changes
Feb 18, 2025
Saizan
reviewed
Feb 19, 2025
Saizan
reviewed
Feb 19, 2025
|
@will-break-it is it intentional that the data for the block (e.g. |
|
That's a good observation, we are indeed duplicating this data now.
|
will-break-it
added a commit
that referenced
this pull request
Feb 25, 2025
* data: add trace schema for haskell & rust * data: add example logs for all events for make validate * data: simplify haskell trace schema * data: remove verbose extract of message kind * data: updated rust schema * data: composed rust message & action types * Trace Schema Changes (#202) * fix: add cpu_time_s field to track total CPU time across cores * fix: consistent naming of RBs across both simulations * refactor: naming of block variants * - refactor(hs) - separate block lifecycle actions from network actions - use shorter block type names (IB/EB/RB/VT) * fix(hs): remove node_name * fix: remove duration_s * fix: remove redundant block kind; tag -> type * fix(hs-schema): add endorse_blocks; payload_bytes * fix(hs-schema): add slot number to base block evnet * fix(hs-schema): remove duplicate payload_bytes for sent & receive events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.