Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: add trace schema for haskell & rust #194

Merged
merged 7 commits into from
Feb 25, 2025
Merged

data: add trace schema for haskell & rust #194

merged 7 commits into from
Feb 25, 2025

Conversation

will-break-it
Copy link
Contributor

  • Draft of current simulation trace schema
  • Serves as base for discussed changes

@will-break-it
Copy link
Contributor Author

Please have a look - this is the current schema for the main branch.
I'll add another subbranch PR for changes discussed.
Let me know if I've missed something.

cc @SupernaviX @Saizan

* fix: add cpu_time_s field to track total CPU time across cores

* fix: consistent naming of RBs across both simulations

* refactor: naming of block variants

* - refactor(hs)
  - separate block lifecycle actions from network actions
  - use shorter block type names (IB/EB/RB/VT)

* fix(hs): remove node_name

* fix: remove duration_s

* fix: remove redundant block kind; tag -> type

* fix(hs-schema): add endorse_blocks; payload_bytes

* fix(hs-schema): add slot number to base block evnet

* fix(hs-schema): remove duplicate payload_bytes for sent & receive events
@will-break-it will-break-it marked this pull request as ready for review February 24, 2025 09:29
@Saizan
Copy link
Contributor

Saizan commented Feb 24, 2025

@WhatisRT @yveshauser could you comment on whether the haskell trace schema contains enough information for conformity testing, and what else is needed otherwise?

@yveshauser
Copy link
Member

@WhatisRT @yveshauser could you comment on whether the haskell trace schema contains enough information for conformity testing, and what else is needed otherwise?

Yes, the schema contains the fields needed for re-constructing a trace. Thanks!

@SupernaviX
Copy link
Contributor

@will-break-it I have PR #206 ready to merge either before or after this one, to make the rust sim actually match this spec

@will-break-it will-break-it merged commit ac1c1d6 into main Feb 25, 2025
6 checks passed
@will-break-it will-break-it deleted the trace-schema branch February 25, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants