Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce flakiness in tests #2379

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Reduce flakiness in tests #2379

merged 2 commits into from
Mar 19, 2025
+25 −17

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Mar 18, 2025 •
edited
Loading

…ndencies

Content

Use the temp_dir generated from test function to initialize dependencies

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2360

@sfauvel sfauvel changed the title Reduce flakiness of test Reduce flakiness in tests Mar 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

Test Results

    3 files  ±0     57 suites  ±0   11m 22s ⏱️ +2s
1 772 tests ±0  1 772 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 170 runs  ±0  2 170 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3bf6040. ± Comparison against base commit ba14422.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview March 18, 2025 17:39 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel marked this pull request as ready for review March 19, 2025 08:49
@sfauvel sfauvel force-pushed the sfa/2360/use_initialize_dependencies_with_test_temp_dir branch from 29a9c69 to 3bf6040 Compare March 19, 2025 13:42
@sfauvel sfauvel temporarily deployed to testing-preview March 19, 2025 13:51 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 81e90f7 into main Mar 19, 2025
36 checks passed
@sfauvel sfauvel deleted the sfa/2360/use_initialize_dependencies_with_test_temp_dir branch March 19, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some unit tests in the CI are flaky
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume