Feat(e2e): support multiple aggregators in the e2e tests #2378

jpraynaud · 2025-03-18T16:25:27Z

Content

This PR includes the adaptation of the e2e tests to support multiple aggregators:

The relay has been updated to support both Passthrough (messages are sent to the configured aggregator endpoint) and P2P (messages are sent to the P2P network) modes for both the signer registration and signature registration. The configuration options have been updated in that sense
The end to end test configuration has evolved:
- number_of_aggregators and number_of_signers are specified
- signers run on block producing nodes and aggregators on full nodes
- use_p2pmode has been replaced by more appropriate use_relays
- relay_signer_registration_mode and relay-signature_registration_mode have been added (used with the use_relays option)
- use_p2p_passive_relays has been set to false by default
RunOnly mode of the e2e test has been adapted to support concurrently multiple aggregators
Spec mode of the e2e test has been adapted to support concurrently multiple aggregators
Slave registration of the aggregator has been fixed as it was not targeting the correct verification keys. The associated integration test has been rewritten for finer testing of evolving Mithril stake distribution for each epoch.

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- All check jobs of the CI have succeeded
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- No new TODOs introduced

Issue(s)

Closes #2361

github-actions · 2025-03-18T16:33:32Z

Test Results

3 files ± 0 57 suites ±0 11m 27s ⏱️ -1s
1 789 tests +10 1 789 ✅ +10 0 💤 ±0 0 ❌ ±0
2 195 runs +10 2 195 ✅ +10 0 💤 ±0 0 ❌ ±0

Results for commit e442474. ± Comparison against base commit 4292395.

♻️ This comment has been updated with latest results.

sfauvel

LGTM
Just some remarks

mithril-aggregator/src/runtime/state_machine.rs

mithril-aggregator/tests/create_certificate_slave.rs

mithril-relay/src/relay/signer.rs

mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs

dlachaume

LGTM

mithril-test-lab/mithril-end-to-end/src/main.rs

mithril-common/src/entities/epoch.rs

mithril-relay/src/repeater.rs

mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs

mithril-test-lab/mithril-end-to-end/src/assertions/exec.rs

Alenar

LGTM with a few caveats.

mithril-aggregator/tests/create_certificate_slave.rs

mithril-test-lab/mithril-end-to-end/Cargo.toml

mithril-aggregator/src/runtime/state_machine.rs

mithril-test-lab/mithril-end-to-end/src/assertions/wait.rs

mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs

mithril-test-lab/mithril-end-to-end/src/end_to_end_spec.rs

- Removed last epoch which was not necessary - Removed unnecessary cycles - Reduced the number of signers per epoch - Use of 'checked_sub' in the 'EpochFixturesMapBuilder'.

…to HTTP response in signer

…the epoch service Instead of having to repeat the call on 'inform_new_epoch' in the state machine for the slave.

When submitting signature to an aggregator with the REST API.

This makes the topology of the P2P network easier to work with.

This will help reduce a lot of flakiness with fast pace devnets as less block producers are running in the network.

* mithril-aggregator from `0.7.25` to `0.7.26` * mithril-common from `0.5.16` to `0.5.17` * mithril-relay from `0.1.38` to `0.1.39` * mithril-end-to-end from `0.4.74` to `0.4.75`

dlachaume

LGTM 👍

mithril-test-lab/mithril-end-to-end/src/main.rs

jpraynaud self-assigned this Mar 18, 2025

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 99077bb to 9ad40fc Compare March 18, 2025 16:50

jpraynaud temporarily deployed to testing-preview March 18, 2025 17:01 — with GitHub Actions Inactive

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 5 times, most recently from cf5d195 to 7c6a300 Compare March 19, 2025 17:47

jpraynaud temporarily deployed to testing-preview March 19, 2025 17:58 — with GitHub Actions Inactive

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 5 times, most recently from de78895 to 42b4d01 Compare March 20, 2025 18:34

jpraynaud marked this pull request as ready for review March 20, 2025 18:35

jpraynaud requested review from Alenar, sfauvel and dlachaume March 20, 2025 18:35

sfauvel approved these changes Mar 21, 2025

View reviewed changes

dlachaume approved these changes Mar 21, 2025

View reviewed changes

Alenar approved these changes Mar 21, 2025

View reviewed changes

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 2 times, most recently from b464797 to 9e47514 Compare March 21, 2025 17:55

Alenar force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 9e47514 to be638e5 Compare March 24, 2025 12:19

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 4 times, most recently from 22a5e26 to c070d80 Compare March 25, 2025 18:07

feat(e2e): update e2e test command line arguments

ed6d240

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 5faa87f to 139e0f3 Compare March 26, 2025 16:38

jpraynaud temporarily deployed to testing-preview March 26, 2025 17:12 — with GitHub Actions Inactive

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 2 times, most recently from 2b9e1de to 56e9331 Compare March 26, 2025 17:34

jpraynaud and others added 12 commits March 27, 2025 16:19

fix(e2e): flakiness in the genesis bootstrap of slave aggregators

ac3755a

refactor(e2e): enhance assertions logs with aggregator name

a302d26

fix(ci): wrong format for next era in some e2e scenarios

550a47d

fix(e2e): era switch done on multiple aggregators

7e1ee64

refactor(aggregator): simplify slave aggregator integration test

2f3dd88

- Removed last epoch which was not necessary - Removed unnecessary cycles - Reduced the number of signers per epoch - Use of 'checked_sub' in the 'EpochFixturesMapBuilder'.

refactor(e2e): better parameter handling with clap

8715c9f

chore(e2e): apply review comments

6d28b9e

refactor(e2e): avoid rwlock of option in specs

fded200

refactor(e2e): simplify chain observer usage

52fb6ee

refactor(e2e): remove dependency to 'mithril-relay'

61ce264

refactor(relay): create function converting mpsc transmission result …

9913eb7

…to HTTP response in signer

feat(relay): add tests for signer relay passthrough/p2p modes

1a1bdbc

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 2 times, most recently from e34fb97 to ee7f8da Compare March 27, 2025 15:50

jpraynaud temporarily deployed to testing-preview March 27, 2025 16:11 — with GitHub Actions Inactive

jpraynaud added 5 commits March 27, 2025 18:58

refactor(aggregator): slave synchronizer updates the next signers in …

db589f3

…the epoch service Instead of having to repeat the call on 'inform_new_epoch' in the state machine for the slave.

fix(relay): aggregator relay accepts 202 codes

bff5187

When submitting signature to an aggregator with the REST API.

fix(e2e): improve protocol parameters to remove flakiness

2830aaf

fix(e2e): do not use passive relays by default

3fa9f42

This makes the topology of the P2P network easier to work with.

refactor(e2e): run aggregators on full nodes

3b9d45c

This will help reduce a lot of flakiness with fast pace devnets as less block producers are running in the network.

jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from ee7f8da to 3b9d45c Compare March 27, 2025 18:00

chore: upgrade crate versions

e442474

* mithril-aggregator from `0.7.25` to `0.7.26` * mithril-common from `0.5.16` to `0.5.17` * mithril-relay from `0.1.38` to `0.1.39` * mithril-end-to-end from `0.4.74` to `0.4.75`

jpraynaud temporarily deployed to testing-preview March 27, 2025 18:11 — with GitHub Actions Inactive

dlachaume approved these changes Mar 28, 2025

View reviewed changes

mithril-test-lab/mithril-end-to-end/src/main.rs Show resolved Hide resolved

jpraynaud merged commit 5fb8826 into main Mar 28, 2025
38 checks passed

jpraynaud deleted the jpraynaud/2361-e2e-test-slave-aggregator branch March 28, 2025 14:38

Feat(e2e): support multiple aggregators in the e2e tests #2378

Feat(e2e): support multiple aggregators in the e2e tests #2378

Uh oh!

Conversation

jpraynaud commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Issue(s)

Uh oh!

github-actions bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

sfauvel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlachaume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alenar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlachaume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud commented Mar 18, 2025 •

edited

Loading

github-actions bot commented Mar 18, 2025 •

edited

Loading