Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(e2e): support multiple aggregators in the e2e tests #2378

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 18, 2025

Content

This PR includes the adaptation of the e2e tests to support multiple aggregators:

  • The relay has been updated to support both Passthrough (messages are sent to the configured aggregator endpoint) and P2P (messages are sent to the P2P network) modes for both the signer registration and signature registration. The configuration options have been updated in that sense
  • The end to end test configuration has evolved:
    • number_of_aggregators and number_of_signers are specified instead of number_of_pool_nodes
    • use_p2pmode has been replaced by more appropriate use_relays
    • relay_signer_registration_mode and relay-signature_registration_mode have been added (used with the use_relays option)
  • RunOnly mode of the e2e test has been adapted to support concurrently multiple aggregators
  • Spec mode of the e2e test has been adapted to support concurrently multiple aggregators
  • Slave registration of the aggregator has been fixed as it was not targeting the correct verification keys. The associated integration test has been rewritten for finer testing of evolving Mithril stake distribution for each epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Closes #2361

@jpraynaud jpraynaud self-assigned this Mar 18, 2025
Copy link

github-actions bot commented Mar 18, 2025

Test Results

    3 files  ±0     57 suites  ±0   11m 49s ⏱️ +14s
1 774 tests +2  1 774 ✅ +2  0 💤 ±0  0 ❌ ±0 
2 172 runs  +2  2 172 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 2ff1fe1. ± Comparison against base commit 81e90f7.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 99077bb to 9ad40fc Compare March 18, 2025 16:50
@jpraynaud jpraynaud temporarily deployed to testing-preview March 18, 2025 17:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 9ad40fc to 8ec788f Compare March 19, 2025 10:49
@jpraynaud jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 2 times, most recently from d403b9e to 915d6cb Compare March 19, 2025 15:14
As master/slave signer registration is only one of the configurations to be tested.
@jpraynaud jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch 2 times, most recently from cf5d195 to 7c6a300 Compare March 19, 2025 17:47
@jpraynaud jpraynaud deployed to testing-preview March 19, 2025 17:58 — with GitHub Actions Active
@jpraynaud jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 7c6a300 to 0cfef53 Compare March 19, 2025 18:10
@jpraynaud jpraynaud force-pushed the jpraynaud/2361-e2e-test-slave-aggregator branch from 0cfef53 to 2ff1fe1 Compare March 19, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2e tests adaptation for multiple aggregators
1 participant