-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(e2e): support multiple aggregators in the e2e tests #2378
Draft
jpraynaud
wants to merge
22
commits into
main
Choose a base branch
from
jpraynaud/2361-e2e-test-slave-aggregator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99077bb
to
9ad40fc
Compare
First aggregator is 'master', and others (if any) are 'slave' to the 'master'.
…ggregators Better P2P relays topology and fix log files collisions.
By providing information about the targeted aggregator in logs and errors.
Which could prevent signature from signers even with loose protocol parameters.
Which can be 'Passthrough' or 'P2P'.
9ad40fc
to
8ec788f
Compare
d403b9e
to
915d6cb
Compare
As master/slave signer registration is only one of the configurations to be tested.
cf5d195
to
7c6a300
Compare
7c6a300
to
0cfef53
Compare
Until we can fix the source of flakiness.
0cfef53
to
2ff1fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the adaptation of the e2e tests to support multiple aggregators:
Passthrough
(messages are sent to the configured aggregator endpoint) andP2P
(messages are sent to the P2P network) modes for both the signer registration and signature registration. The configuration options have been updated in that sensenumber_of_aggregators
andnumber_of_signers
are specified instead ofnumber_of_pool_nodes
use_p2pmode
has been replaced by more appropriateuse_relays
relay_signer_registration_mode
andrelay-signature_registration_mode
have been added (used with theuse_relays
option)RunOnly
mode of the e2e test has been adapted to support concurrently multiple aggregatorsSpec
mode of the e2e test has been adapted to support concurrently multiple aggregatorsPre-submit checklist
Issue(s)
Closes #2361