Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize STM code #2373

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Organize STM code #2373

merged 3 commits into from
Mar 18, 2025

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Mar 14, 2025 •
edited
Loading

Content

This PR covers:

  • Implementations right after their structures,
  • Property tests re-ordered,

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2369

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

Test Results

    3 files  ±0     56 suites  ±0   11m 10s ⏱️ -26s
1 764 tests  - 1  1 764 ✅  - 1  0 💤 ±0  0 ❌ ±0 
2 162 runs   - 1  2 162 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit b15c070. ± Comparison against base commit 6408d5c.

This pull request removes 1 test. 
mithril-stm ‑ multi_sig::tests::test_gen

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt requested a review from jpraynaud March 17, 2025 13:06
@curiecrypt curiecrypt marked this pull request as ready for review March 17, 2025 13:07
jpraynaud
jpraynaud reviewed Mar 18, 2025
View reviewed changes
@curiecrypt curiecrypt requested a review from jpraynaud March 18, 2025 13:09
jpraynaud
jpraynaud approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

curiecrypt and others added 2 commits March 18, 2025 17:25
@curiecrypt
organize stm
0491789 
organize merkle tree

organize key reg

organize error

fmt and clippy

organize tests in src

remove unused import
@curiecrypt
Apply suggestions from code review
6f89bfc 
Co-authored-by: Jean-Philippe Raynaud <[email protected]>

remove comments

remove test comments
@curiecrypt curiecrypt force-pushed the curiecrypt/organize-stm branch 2 times, most recently from ee16132 to 4a55c3f Compare March 18, 2025 14:32
@curiecrypt
change log and crates version
b15c070 
changelog

change log fmt

change log prettier
@curiecrypt curiecrypt force-pushed the curiecrypt/organize-stm branch from c66fe98 to b15c070 Compare March 18, 2025 14:49
@curiecrypt curiecrypt merged commit 2614ed3 into main Mar 18, 2025
36 checks passed
@curiecrypt curiecrypt deleted the curiecrypt/organize-stm branch March 18, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curiecrypt @jpraynaud