Improve remote store eval time #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment the reason so we don't regress it? |
|
Actually I'm not sure if this fixes it. I'll mark it as draft for now |
|
Actually I'm not even sure what I want it to do is possible. As far as I can tell, whatever I do it will create a string with a context depending on the derivation. And each version of this will rebuild the derivation when imported. |
TeofilC
force-pushed
the
teo/improve-remote-store-perf
branch
from
08166ec to
4de0315
Compare
|
I've gotten it working now. We needed to do unsafeDiscardStringContext like we do elsewhere in the file. And I've added a comment |
This code used to put the .drv path into the string context for each package. That meant we had to query the store each time one of these was evaluated for the out path. This is pretty quick when using a non-remote store. But the latency with the remote store really slows us down. We should just calculate the outPath once instead, and use that throughout.
TeofilC
force-pushed
the
teo/improve-remote-store-perf
branch
from
4de0315 to
4b7364b
Compare
hamishmack
merged commit a96cf6c
into
input-output-hk:master
7546 of 7548 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code used to put the .drv path into the string context for each package. That meant we had to query the store each time one of these was evaluated for the out path. This is pretty quick when using a non-remote store. But the latency with the remote store really slows us down.
We should just calculate the outPath once instead, and use that throughout.