Enable ghc plugin test for 9.8.1 and above #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4dc4p
added a commit
to m4dc4p/haskell-nix-9.8
that referenced
this pull request
Feb 9, 2024
* Use breakpoint instead of polysemy (for simplicity) * Apply fixes from input-output-hk/haskell.nix#2158
m4dc4p
reviewed
Feb 12, 2024
| @@ -6,6 +6,9 @@ let | |||
| project = project' { | |||
| inherit compiler-nix-name evalPackages; | |||
| src = testSrc "plugin"; | |||
| modules = [{ | |||
| reinstallableLibGhc = builtins.compareVersions buildPackages.haskell-nix.compiler.${compiler-nix-name}.version "9.8.1" < 0; | |||
There was a problem hiding this comment.
Is there a way to make this automatic, e.g. as part of comp-builder.nix or similar? Otherwise any project building with 9.8.1. & plugins will have this same problem. (Apologies for commenting on a merged PR; I only thought of this over the weekend ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.