Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): adding author list to document metadata to store in db #2059

Merged
merged 6 commits into from
Mar 21, 2025
Merged

feat(cat-voices): adding author list to document metadata to store in db #2059

merged 6 commits into from
Mar 21, 2025

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Mar 20, 2025 •
edited by dtscalac
Loading

Description

Adding catalystId in metadata for local and draft db to know which proposal belongs to auth user.

Related Issue(s)

Closes #2044

Description of Changes

Adding List in metadata that will be filled with CatalystId string representation.

Breaking Changes

N/A

Screenshots

N/A

Related Pull Requests

N/A

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added dart Pull requests that update Dart code F14 labels Mar 20, 2025
@LynxLynxx LynxLynxx added this to the Fund14 Technical Readiness milestone Mar 20, 2025
@LynxLynxx LynxLynxx self-assigned this Mar 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 653/658}$ | ${\color{red}Fail: 0/658}$ |

@LynxLynxx LynxLynxx added the review me PR is ready for review label Mar 20, 2025
@LynxLynxx LynxLynxx marked this pull request as ready for review March 20, 2025 14:14
dtscalac
dtscalac previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LynxLynxx @dtscalac
fix: Update catalyst_voices/packages/internal/catalyst_voices_reposit…
dbd22f7 
…ories/test/src/database/dao/drafts_dao_test.dart

Co-authored-by: Dominik Toton <[email protected]>
damian-molinski
damian-molinski approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LynxLynxx LynxLynxx merged commit 7edb712 into main Mar 21, 2025
40 checks passed
@LynxLynxx LynxLynxx deleted the feat/2044-catalystId-documents branch March 21, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@dtscalac dtscalac dtscalac left review comments

Assignees

@LynxLynxx LynxLynxx

Labels
dart Pull requests that update Dart code F14 review me PR is ready for review
Projects
Catalyst
Status: ✅ Done
Milestone
Fund14 Technical Readiness
Development

Successfully merging this pull request may close these issues.

add catalystID to proposal metadata
3 participants
@LynxLynxx @damian-molinski @dtscalac