fix(cat-gateway): Fix endpoints cardano/assets and cardano/registrations/cip36 endpoints
#1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
…ake_pk_from_vote_key.rs Co-authored-by: bkioshn <[email protected]>
Co-authored-by: bkioshn <[email protected]>
…valid.rs Co-authored-by: bkioshn <[email protected]>
Co-authored-by: bkioshn <[email protected]>
bkioshn
reviewed
Mar 17, 2025
| @@ -1,9 +1,13 @@ | |||
| SELECT problem_report, | |||
| SELECT nonce, | |||
There was a problem hiding this comment.
Minor issue about consistency: The file name is missing s or registration, should be get_invalid_registrations_w_stake_pk.cql so it is consistent with get_registrations_w_stake_pk
| include_str!("../cql/get_registrations_w_stake_addr.cql"); | ||
| /// Get registrations from stake public key query. | ||
| const GET_REGISTRATIONS_FROM_STAKE_PK_QUERY: &str = | ||
| include_str!("../cql/get_registrations_w_stake_pk.cql"); | ||
|
|
||
| /// Get registration | ||
| #[derive(SerializeRow)] | ||
| pub(crate) struct GetRegistrationParams { | ||
| /// Stake address. |
There was a problem hiding this comment.
Typo
Suggested change
| /// Stake address. | |
| /// Stake public key. |
|
|
||
| let mut invalid_registrations_iter = GetInvalidRegistrationQuery::execute( | ||
| /// Get registrations given a stake address, it can be time specific based on asat param, | ||
| /// or the latest registration returned if no asat given. |
There was a problem hiding this comment.
This should be all registration returned? Since it is doing <= slotno
Maybe can add "The first one is the latest one"
| /// Production Stake Address Identifier | ||
| pub(crate) const STAKE_PROD: &str = "stake"; | ||
| /// Test Stake Address Identifier | ||
| pub(crate) const STAKE_TEST: &str = "stake_test"; | ||
| /// Bech32 Match Pattern | ||
| const BECH32: &str = "[a,c-h,j-n,p-z,0,2-9]"; | ||
| /// Length of the encoded address (for type 0 - 3). |
There was a problem hiding this comment.
Avoiding confusion
/// Length of the encoded address that have 2 parts (for Shelley address type 0 - 3).
const ENCODED_TWO_PART_ADDR_LEN: usize = 98;
/// Length of the encoded address that have 1 part (for Shelley address type 6 - 7, and stake address).
const ENCODED_ONE_PART_ADDR_LEN: usize = 53;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description