-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cat-voices): adds web tests for flutter unit tests #1948
base: main
Are you sure you want to change the base?
Conversation
@kukkok3 The |
✅ Test Report | |
@dtscalac Sorry I just saw your comment.
|
@@ -98,9 +97,13 @@ check-license: | |||
RUN melos run license-check | |||
|
|||
# Run unit tests | |||
test-unit: | |||
test-unit-native: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename it as well in: https://github.com/input-output-hk/catalyst-voices/blob/main/catalyst_voices/justfile#L26
flutter_test: | ||
sdk: flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package was designed as pure dart package, it means it should have no dependency on flutter. For testing we use test
package, not flutter_test
. What's the reason to include the flutter_test
package?
flutter_test: | ||
sdk: flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package was designed as pure dart package, it means it should have no dependency on flutter. For testing we use test
package, not flutter_test
. What's the reason to include the flutter_test
package?
flutter_test: | ||
sdk: flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this package has no tests and won't have them, do we need the test framework here?
flutter_test: | ||
sdk: flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be required for this package
Description
This PR is introducing a new melos script to run flutter unit tests on web
Related Issue(s)
List the issue numbers related to this pull request.
Description of Changes
Provide a clear and concise description of what the pull request changes.
Breaking Changes
Describe any breaking changes and the impact.
Screenshots
If applicable, add screenshots to help explain your changes.
Related Pull Requests
If applicable, list any related pull requests.
Please confirm the following checks