feat(cat-gateway): cardano/rbac/registrations endpoint API definition.
#1936
Conversation
Co-authored-by: Steven Johnson <[email protected]>
|
✅ Test Report | |
|
✅ Test Report | |
catalyst-gateway/bin/src/service/api/cardano/rbac/registrations_get/cip509.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/service/common/types/cardano/catalyst_id.rs
Outdated
Show resolved
Hide resolved
…ion_id.rs Co-authored-by: bkioshn <[email protected]>
…_id.rs Co-authored-by: Stanislav Tkach <[email protected]>
…ntation (#2008) * RBAC registrations endpoint business logic implementation * catalyst_id_from_stake function * UnprocessableContent * remove attribute * Update catalyst-gateway/bin/src/service/api/cardano/rbac/registrations_get/mod.rs Co-authored-by: Alex Pozhylenkov <[email protected]> * Import --------- Co-authored-by: Alex Pozhylenkov <[email protected]>
| use crate::service::common::{ | ||
| self, | ||
| auth::none_or_api_key::NoneOrApiKey, |
There was a problem hiding this comment.
The API key was specifically hidden on this endpoint so it would not appear in the API, as was the "ALL" option.
They are internal only options not to be advertised through the public API.
| @@ -142,10 +142,10 @@ pub(crate) struct Cip36Details { | |||
| pub payment_address: Option<common::types::cardano::cip19_shelley_address::Cip19ShelleyAddress>, | |||
| /// If the payment address is a script, then it can not be payed rewards. | |||
| #[oai(default)] | |||
| pub is_payable: common::types::cardano::boolean::IsPayable, | |||
| pub is_payable: common::types::generic::boolean::BooleanFlag, | |||
There was a problem hiding this comment.
Why remove the specific types?
There was a problem hiding this comment.
They are basically just a boolean flags as BooleanFlag so just removed redundant types.
The description for this field is overlay the default description of the BooleanFlag type.
There was a problem hiding this comment.
I see your point, but IsCip15 defaults to false, while IsPayable defaults to true, which is why they need to be separate types. This will also affect the OpenAPI spec rendering. Do you have a workaround for handling these default values?
There was a problem hiding this comment.
Good point, missed that. Need to take a look is it possible to make a workaround without providing additional types
| #[derive(Debug, Clone, Object)] | ||
| #[oai(example = true)] | ||
| pub(crate) struct Cip509 { | ||
| /// A registration purpose (`UUIDv4`). |
There was a problem hiding this comment.
This endpoint is supposed to return the complete unified registration as at now, not ll the raw transactions.
This is the wrong response type.
catalyst-gateway/bin/src/service/common/types/cardano/query/cat_id_or_stake.rs
Show resolved
Hide resolved
Description
Added a new endpoint and get rid of unneeded RBAC endpoints.
Added just an API definition of the
cardano/rbac/registrationsendpoint.Also contains #2008
Related Issue(s)
Closes #1923