Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-gateway): Add stub endpoints to minimally work with norns 1/2 #1055

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Oct 28, 2024

Description

Added stub endpoints to support norns and made the interface minimally work with norns.
This is the half part of endpoints listed in the ticket's related epic.

Related Issue(s)

Closes #1046

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
@apskhem apskhem added enhancement New feature or request draft Draft labels Oct 28, 2024
@apskhem apskhem self-assigned this Oct 28, 2024
@apskhem apskhem linked an issue Oct 28, 2024 that may be closed by this pull request
6 tasks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Test Report | P a s s : 320 / 320 | F a i l : 0 / 320 |

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
@apskhem apskhem marked this pull request as draft October 28, 2024 14:10

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Oct 29, 2024
@apskhem apskhem added this to the M4: Voting & Delegation milestone Oct 29, 2024
@apskhem apskhem marked this pull request as ready for review October 29, 2024 12:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@apskhem apskhem changed the title feat(cat-gateway): Add stub endpoints to support norns feat(cat-gateway): Add stub endpoints to minimally work with norns Oct 29, 2024
@apskhem apskhem changed the title feat(cat-gateway): Add stub endpoints to minimally work with norns feat(cat-gateway): Add stub endpoints to minimally work with norns 1/2 Oct 29, 2024
apskhem and others added 3 commits November 5, 2024 14:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
@apskhem apskhem requested a review from bkioshn November 5, 2024 12:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@apskhem apskhem marked this pull request as ready for review November 5, 2024 13:08
@apskhem apskhem added the review me PR is ready for review label Nov 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Report | P a s s : 320 / 320 | F a i l : 0 / 320 |

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Report | P a s s : 320 / 320 | F a i l : 0 / 320 |

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Report | P a s s : 320 / 320 | F a i l : 0 / 320 |

@apskhem apskhem marked this pull request as draft November 11, 2024 12:54
@minikin minikin added the draft Draft label Nov 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Test Report | P a s s : 29 / 29 | F a i l : 0 / 29 |

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Test Report | P a s s : 331 / 331 | F a i l : 0 / 331 |

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
@stevenj stevenj removed the review me PR is ready for review label Nov 26, 2024
@stevenj
Copy link
Collaborator

stevenj commented Nov 26, 2024

This PR is blocked, as we may not require these endpoints.
Final decision on what to do with these is currently deferred.

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj

Verified

This commit was signed with the committer’s verified signature.
apskhem Apisit Ritruengroj
@stevenj stevenj added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Nov 29, 2024
@github-actions github-actions bot deleted the feat/norns-endpoints-stub branch January 13, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet do not review yet Do not review yet draft Draft enhancement New feature or request
Projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add stub endpoints to support norns
5 participants