Skip to content

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Sep 1, 2025

Description

Implements the functional validation of a new doc version that verifies that the authors of the previous (latest) version are exactly the same.

Considerations

Current specifications do not clearly state what the validation of author signatures should involve. For example, does signature order matter? can there be new authors?

Closes #492 .

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku self-assigned this Sep 1, 2025
@saibatizoku saibatizoku added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Sep 1, 2025
@saibatizoku saibatizoku moved this from New to 🏗 In progress in Catalyst Sep 1, 2025
@saibatizoku saibatizoku moved this from 🏗 In progress to 👀 In review in Catalyst Sep 1, 2025
@saibatizoku saibatizoku added the review me PR is ready for review label Sep 1, 2025
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Test Report | ${\color{lightgreen}Pass: 425/425}$ | ${\color{red}Fail: 0/425}$ |

@saibatizoku saibatizoku force-pushed the feat/signed-doc-original-author-validation branch from 425ff05 to ed6d5e4 Compare September 1, 2025 19:10
@saibatizoku saibatizoku requested a review from stevenj September 1, 2025 21:41
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 8c44385 into main Sep 2, 2025
30 of 32 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-doc-original-author-validation branch September 2, 2025 06:25
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

OriginalAuthorsRule validation rule
2 participants