Skip to content

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Aug 8, 2025

Description

Fixed an issue of not updating a mithril stats when a new snapshot was downloaded.

Related Issue(s)

Related to input-output-hk/catalyst-voices#2950

Description of Changes

  • Added a new new_live_total_blocks function, which updates only chain_stats.live.blocks stats
  • Modified new_mithril_update, to update only mithril related stats.
  • Fixed live_sync_backfill_and_purge, added missing new_mithril_update calls, to properly update mithril stats with the freshly downloaded snapshot.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy requested a review from stevenj August 8, 2025 19:37
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review August 9, 2025 09:43
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review requires architect review Requires at least 1 architect to sign off on PR before merge. labels Aug 9, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Aug 9, 2025
Copy link
Contributor

github-actions bot commented Aug 9, 2025

Test Report | ${\color{lightgreen}Pass: 364/364}$ | ${\color{red}Fail: 0/364}$ |

@Mr-Leshiy Mr-Leshiy merged commit baca327 into main Aug 11, 2025
33 of 39 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/chain-follower-stats branch August 11, 2025 07:56
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Aug 11, 2025
Mr-Leshiy added a commit that referenced this pull request Aug 11, 2025
…ts with the new snapshot (#467)

* update new_mithril_update and live_sync_backfill_and_purge

* wip

* wip
Mr-Leshiy added a commit that referenced this pull request Aug 11, 2025
…ts with the new snapshot (#467) (#469)

* update new_mithril_update and live_sync_backfill_and_purge

* wip

* wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires architect review Requires at least 1 architect to sign off on PR before merge. review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants