chore(rust/cardano-chain-follower): Cleanup updating follower state after getting a new update #250
+114
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Test Report | |
stevenj
reviewed
Mar 24, 2025
stevenj
requested changes
Mar 24, 2025
stevenj
requested changes
Mar 25, 2025
stevenj
requested changes
Mar 25, 2025
Co-authored-by: Steven Johnson <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>
stevenj
approved these changes
Mar 25, 2025
Mr-Leshiy
added a commit
that referenced
this pull request
Mar 25, 2025
…245) * fix(rust/cardano-chain-follower): fix immutable roll forward event generation * fix(rust/cardano-chain-follower): remove excessive debug log * fix(rust/cardano-chain-follower): Properly log and handle Immutable Roll Forwards in the example * fix(rust/cardano-chain-follower): Add comments and adjust debug log to be more accurate * fix(rust/cardano-chain-follower): Improve comments and update immutable_tip in the `update_current` function only. * fix(rust/cardano-chain-follower): Finally fixes reporting of immutable roll forward events. * chore(rust/cardano-chain-follower): Cleanup updating follower state after getting a new update (#250) * cleanup update_current method usage * wip * add tests * Update rust/cardano-chain-follower/src/follow.rs Co-authored-by: Steven Johnson <[email protected]> * Update rust/cardano-chain-follower/src/follow.rs Co-authored-by: Steven Johnson <[email protected]> * wip * fix spelling --------- Co-authored-by: Steven Johnson <[email protected]> --------- Co-authored-by: Alex Pozhylenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made a small cleanup of localising applying update for the follower state under one method
update_current.