-
Notifications
You must be signed in to change notification settings - Fork 0
feat(rust/rbac-registration): Record each role data fields #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
stanislav-tkach
previously approved these changes
Mar 19, 2025
Signed-off-by: bkioshn <[email protected]>
stevenj
requested changes
Mar 21, 2025
rust/rbac-registration/src/cardano/cip509/types/role_data_record.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Mr-Leshiy
requested changes
Mar 26, 2025
rust/rbac-registration/src/cardano/cip509/types/role_data_record.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: bkioshn <[email protected]>
stanislav-tkach
previously approved these changes
Mar 26, 2025
rust/rbac-registration/src/cardano/cip509/types/role_data_record.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: bkioshn <[email protected]>
Mr-Leshiy
previously approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but I would also wait an approval from @stanislav-tkach
stevenj
requested changes
Mar 27, 2025
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Mr-Leshiy
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stanislav-tkach
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Record each role data fields + add function for retrieving public key from certs
Related Issue(s)
Closes #241 #255
Description of Changes
Each role data fields are record separately which is stored in
role_data_record
.This
role_data_record
is difference fromrole_data_history
whererole_data_history
store the whole role data at the specific point in time.For example, for role 0,
Each entry of Roledata as shown above will be store in
role_data_history
The
role_data_record
of role 0 will bedeleted
, it is also considered as rotation.Breaking Changes
Renaming
all_role_data
->role_data_history
role_data
->role_data_record
and the structure changesTest
This change need to be tested again once test data is fully prepared
input-output-hk/catalyst-voices#2037
Please confirm the following checks