Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Replace base64-url with base64 #234

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mr-Leshiy
Copy link
Contributor

Description

Replace base64-url which is simply just a wrapper over base64 crate https://github.com/magiclen/base64-url/blob/7bcd29e6b1c21bc4b2592d40d9b493ab4ff3fad4/Cargo.toml#L16.
Simplify our dependency tree.

@Mr-Leshiy Mr-Leshiy self-assigned this Mar 11, 2025
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Mar 11, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 302/302}$ | ${\color{red}Fail: 0/302}$ |

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a necessary change. Not prioritized.
This change would then require a release and bumping other crates.
Not approved.

@stevenj stevenj added do not merge yet PR is not ready to merge yet Deferred Deffered due to reprioritization labels Mar 12, 2025
@stevenj stevenj marked this pull request as draft March 12, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deferred Deffered due to reprioritization do not merge yet PR is not ready to merge yet review me PR is ready for review
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

3 participants