Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ginko version #391

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: ginko version #391

merged 1 commit into from
Mar 18, 2025

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Mar 17, 2025

Description

Ginko v2.23.0 needs go version 1.23.0 while we are running go 1.22.4. This PR pins ginko to version 2.22.2 so we dont need to upgrade go

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #123, Resolves #456 Fixes #367

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Sorry, something went wrong.

@kukkok3 kukkok3 changed the title fix ginko version fix: ginko version Mar 17, 2025
@kukkok3 kukkok3 marked this pull request as ready for review March 17, 2025 21:31
@kukkok3 kukkok3 requested a review from stevenj March 17, 2025 21:54
@kukkok3 kukkok3 enabled auto-merge (squash) March 17, 2025 21:59
@kukkok3 kukkok3 merged commit 6d69e9d into master Mar 18, 2025
36 of 40 checks passed
@kukkok3 kukkok3 deleted the fix/pin-ginko-version branch March 18, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants