-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): withdrawal calculation in computeImplicitCoin [LW-12198] #1602
fix(core): withdrawal calculation in computeImplicitCoin [LW-12198] #1602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @przemyslaw-wlodek 👏
|
b8c1e95
@@ -179,7 +194,9 @@ export const computeImplicitCoin = ( | |||
proposalProcedures | |||
); | |||
|
|||
const withdrawalsTotal = (withdrawals && BigIntMath.sum(withdrawals.map(({ quantity }) => quantity))) || 0n; | |||
const hasRewardAccount = !!rewardAccounts?.length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @przemyslaw-wlodek
ed95198
to
f246be7
Compare
37fe38c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
37fe38c
to
9e1b658
Compare
9f919ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @przemyslaw-wlodek 🚀
9f919ca
to
46771ce
Compare
Context
See LW-12198
Proposed Solution
Calculate withdrawals only for own reward accounts.