-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/lw 10575 fix roundtrip error in base wallet #1321
Feat/lw 10575 fix roundtrip error in base wallet #1321
Conversation
2002c6f
to
b95f09c
Compare
b95f09c
to
82abc3f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @AngelCastilloB ! 💪
091972a
to
aae8432
Compare
aae8432
to
e731cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🕵️
Context
We introduced a bug that was causing transaction submitted by dApps to be round tripped. Causing in some cases differences in the CBOR representation, which lead to an invalid witness.
Proposed Solution
Make sure the wallet only ever signs the original CBOR of the tx body.