-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LW-10504]add timeout transaction inspectors #1313
[LW-10504]add timeout transaction inspectors #1313
Conversation
cba2906
to
9ef8db8
Compare
|
9ef8db8
to
f399a04
Compare
const { inputResolver, addresses, rewardAccounts, protocolParameters, assetProvider, dRepKeyHash } = args; | ||
const resolvedInputs = await resolveInputs(tx.body.inputs, inputResolver); | ||
const { | ||
inputResolver, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should memoize inputResolver in lace as both inspectors are calling it with same inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
38194f5
to
3a81510
Compare
…transactionSummaryInspector BREAKING CHANGE: add timeout prop to inspectors for them to return a timeout error
3a81510
to
e0333fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! 🚀
Context
The
transactionSummaryInspector
andtokenTransferInspector
do not return a timeout error currently, when no inputs are resolved.Proposed Solution
We add a
timeout
prop so the consumer can set up the time in MS in which they want the timeout to return if no inputs are found.Important Changes Introduced
transactionSummaryInspector
andtokenTransferInspector
now require atimeout
prop.