chore(hardware-trezor): refactor TrezorKeyAgent to use Transform interface #1096

tomislavhoracek · 2024-02-13T18:37:34Z

This PR introduces a TrezorKeyAgent Transform interface refactor

Context

as per Slack: https://input-output-rnd.slack.com/archives/C05GY0FSW73/p1707252256148049

github-actions · 2024-02-13T18:53:36Z

Standard DiffPost

This PR would generate the following kubectl diff:

Preview

diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-14 13:21:51.329566527 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-14 13:21:51.329566527 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:ckifi60diw14lzqh5d282y0i2fc79l39
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-14 13:21:51.389566557 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-14 13:21:51.389566557 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-14 13:21:51.441566581 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-14 13:21:51.441566581 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-14 13:21:51.497566609 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-14 13:21:51.497566609 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:ckifi60diw14lzqh5d282y0i2fc79l39
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-14 13:21:51.557566637 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-14 13:21:51.557566637 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:ckifi60diw14lzqh5d282y0i2fc79l39
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-14 13:21:51.609566662 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-14 13:21:51.609566662 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:ckifi60diw14lzqh5d282y0i2fc79l39
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-14 13:21:51.665566687 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-14 13:21:51.665566687 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:ckifi60diw14lzqh5d282y0i2fc79l39
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-747982017/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-14 13:21:51.721566716 +0000
+++ /tmp/MERGED-3834919188/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-14 13:21:51.721566716 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:ckifi60diw14lzqh5d282y0i2fc79l39
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-747982017/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-3834919188/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-747982017/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-14 13:21:51.781566744 +0000
+++ /tmp/MERGED-3834919188/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-14 13:21:51.781566744 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-747982017/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-3834919188/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-747982017/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-14 13:21:51.829566766 +0000
+++ /tmp/MERGED-3834919188/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-14 13:21:51.829566766 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-747982017/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-3834919188/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-747982017/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-14 13:21:51.885566792 +0000
+++ /tmp/MERGED-3834919188/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-14 13:21:51.885566792 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-747982017/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3834919188/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-747982017/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-14 13:21:51.941566820 +0000
+++ /tmp/MERGED-3834919188/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-14 13:21:51.941566820 +0000
@@ -20,7 +20,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-747982017/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3834919188/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-747982017/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-14 13:21:51.997566846 +0000
+++ /tmp/MERGED-3834919188/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-14 13:21:51.997566846 +0000
@@ -18,7 +18,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-14 13:21:51.117566467 +0000
+++ /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-14 13:21:51.117566467 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-14 13:21:51.169566478 +0000
+++ /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-14 13:21:51.169566478 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-14 13:21:51.217566488 +0000
+++ /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-14 13:21:51.221566489 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-747982017/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-14 13:21:51.273566501 +0000
+++ /tmp/MERGED-3834919188/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-14 13:21:51.273566501 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: ecfef1e2837eba31f81fca4091b91d4aad7d5161
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

packages/hardware-trezor/src/transformers/keyPaths.ts

packages/hardware-trezor/src/transformers/tx.ts

mkazlauskas

Nice work! 🚀

rhyslbw · 2024-02-14T12:44:13Z

packages/hardware-trezor/src/transformers/assets.ts

@@ -12,7 +13,7 @@ const comparePolicyIdCanonically = (a: Trezor.CardanoAssetGroup, b: Trezor.Carda
  // PolicyId is always of the same length
  a.policyId > b.policyId ? 1 : -1;

-const tokenMapToAssetGroup = (tokenMap: Cardano.TokenMap, isMint: boolean): Trezor.CardanoAssetGroup[] => {
+const tokenMapToAssetGroup: Transform<Cardano.TokenMap, Trezor.CardanoAssetGroup[]> = (tokenMap, isMint) => {


Interesting, so this just needed the generic type applied

packages/hardware-trezor/src/transformers/auxiliaryData.ts

tomislavhoracek · 2024-02-14T13:05:04Z

@mkazlauskas approval was dismissed because of the last e69f4b6. Could you check it please ?

rhyslbw

Well done @tomislavhoracek 🎉

rhyslbw · 2024-02-14T13:11:56Z

Please squash

…rface

tomislavhoracek · 2024-02-14T13:13:16Z

@rhyslbw squashed

tomislavhoracek marked this pull request as draft February 13, 2024 18:38

tomislavhoracek force-pushed the chore/lw-9751-trezor-key-agent-refactor-to-use-transform branch from 357e3f4 to beda310 Compare February 13, 2024 18:41

tomislavhoracek self-assigned this Feb 13, 2024

tomislavhoracek added the refactor label Feb 13, 2024

tomislavhoracek requested review from AngelCastilloB, rhyslbw and mkazlauskas February 13, 2024 18:44

tomislavhoracek marked this pull request as ready for review February 13, 2024 18:45

tomislavhoracek requested a review from DominikGuzei February 13, 2024 18:47

mkazlauskas reviewed Feb 14, 2024

View reviewed changes

packages/hardware-trezor/src/transformers/keyPaths.ts Outdated Show resolved Hide resolved

packages/hardware-trezor/src/transformers/tx.ts Show resolved Hide resolved

mkazlauskas previously approved these changes Feb 14, 2024

View reviewed changes

tomislavhoracek force-pushed the chore/lw-9751-trezor-key-agent-refactor-to-use-transform branch from bda86db to afa91dc Compare February 14, 2024 08:28

rhyslbw requested changes Feb 14, 2024

View reviewed changes

tomislavhoracek dismissed mkazlauskas’s stale review via e69f4b6 February 14, 2024 13:00

mkazlauskas approved these changes Feb 14, 2024

View reviewed changes

rhyslbw self-requested a review February 14, 2024 13:11

rhyslbw approved these changes Feb 14, 2024

View reviewed changes

chore(hardware-trezor): refactor TrezorKeyAgent to use Transform inte…

76ab44c

…rface

tomislavhoracek force-pushed the chore/lw-9751-trezor-key-agent-refactor-to-use-transform branch from e69f4b6 to 76ab44c Compare February 14, 2024 13:12

tomislavhoracek merged commit 02d17d4 into master Feb 14, 2024
7 checks passed

tomislavhoracek deleted the chore/lw-9751-trezor-key-agent-refactor-to-use-transform branch February 14, 2024 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(hardware-trezor): refactor TrezorKeyAgent to use Transform interface #1096

chore(hardware-trezor): refactor TrezorKeyAgent to use Transform interface #1096

tomislavhoracek commented Feb 13, 2024

github-actions bot commented Feb 13, 2024 •

edited

Loading

mkazlauskas left a comment

rhyslbw Feb 14, 2024

tomislavhoracek commented Feb 14, 2024

rhyslbw left a comment

rhyslbw commented Feb 14, 2024

tomislavhoracek commented Feb 14, 2024

chore(hardware-trezor): refactor TrezorKeyAgent to use Transform interface #1096

chore(hardware-trezor): refactor TrezorKeyAgent to use Transform interface #1096

Conversation

tomislavhoracek commented Feb 13, 2024

Context

github-actions bot commented Feb 13, 2024 • edited Loading

Standard DiffPost

mkazlauskas left a comment

Choose a reason for hiding this comment

rhyslbw Feb 14, 2024

Choose a reason for hiding this comment

tomislavhoracek commented Feb 14, 2024

rhyslbw left a comment

Choose a reason for hiding this comment

rhyslbw commented Feb 14, 2024

tomislavhoracek commented Feb 14, 2024

github-actions bot commented Feb 13, 2024 •

edited

Loading