Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cardano-services): test ogmios utils #1094

Merged
merged 1 commit into from
Feb 14, 2024
Merged

test(cardano-services): test ogmios utils #1094

merged 1 commit into from
Feb 14, 2024

Conversation

mirceahasegan
Copy link
Contributor

Context

These tests previously relied on a mocked OgmiosServer, making them tightly coupled with the ogmios implementation.
Since our ogmios implementation was abstracted behind the OgmiosCardanoNode/OgmiosObservableCardanoNode, we can mock them and test the factory utils.

Proposed Solution

Complete rewrite to not require ogmios server.
Test only the ogmios.ts utils.

Important Changes Introduced

@mirceahasegan mirceahasegan self-assigned this Feb 12, 2024
@mirceahasegan mirceahasegan force-pushed the test/lw-8944-reenable-ogmios-cardano-services-tests branch from 2ff0e16 to 29d3c7c Compare February 12, 2024 17:53
@github-actions GitHub Actions
Copy link

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-12 18:04:03.636497706 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-12 18:04:03.636497706 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1rzasim5hd17sxf28is8ir9fq6mpk6p6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-12 18:04:03.664497698 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-12 18:04:03.664497698 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 18:04:03.688497694 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 18:04:03.688497694 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-12 18:04:03.716497687 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-12 18:04:03.716497687 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1rzasim5hd17sxf28is8ir9fq6mpk6p6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 18:04:03.744497680 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 18:04:03.744497680 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1rzasim5hd17sxf28is8ir9fq6mpk6p6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-12 18:04:03.768497676 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-12 18:04:03.768497676 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1rzasim5hd17sxf28is8ir9fq6mpk6p6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-12 18:04:03.792497671 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-12 18:04:03.796497669 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1rzasim5hd17sxf28is8ir9fq6mpk6p6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1367515063/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 18:04:03.820497664 +0000
+++ /tmp/MERGED-557709892/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 18:04:03.820497664 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "8"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 8
+  generation: 9
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:2a9qvpsiryyfpp3y5q5zx918zb31gym2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1rzasim5hd17sxf28is8ir9fq6mpk6p6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1367515063/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-557709892/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-1367515063/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-12 18:04:03.848497658 +0000
+++ /tmp/MERGED-557709892/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-12 18:04:03.848497658 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1367515063/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-557709892/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-1367515063/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-12 18:04:03.876497651 +0000
+++ /tmp/MERGED-557709892/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-12 18:04:03.876497651 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1367515063/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-557709892/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-1367515063/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-12 18:04:03.920497642 +0000
+++ /tmp/MERGED-557709892/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-12 18:04:03.920497642 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1367515063/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-557709892/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1367515063/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-12 18:04:03.956497635 +0000
+++ /tmp/MERGED-557709892/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-12 18:04:03.956497635 +0000
@@ -20,7 +20,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1367515063/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-557709892/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1367515063/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 18:04:04.000497625 +0000
+++ /tmp/MERGED-557709892/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 18:04:04.000497625 +0000
@@ -18,7 +18,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-12 18:04:03.544497726 +0000
+++ /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-12 18:04:03.544497726 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 18:04:03.568497721 +0000
+++ /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 18:04:03.568497721 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 18:04:03.588497716 +0000
+++ /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 18:04:03.588497716 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1367515063/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 18:04:03.608497711 +0000
+++ /tmp/MERGED-557709892/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 18:04:03.608497711 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 638dddd96c0687f062913232785b9ecab19d69df
+    app.kubernetes.io/version: 83066501ed56a4cf5d5d5ad74f5533b355e15039
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

iccicci
iccicci approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

mkazlauskas
mkazlauskas approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@mirceahasegan mirceahasegan merged commit 9560147 into conway-era Feb 14, 2024
7 checks passed
@mirceahasegan mirceahasegan deleted the test/lw-8944-reenable-ogmios-cardano-services-tests branch February 14, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mchappell mchappell Awaiting requested review from mchappell

@AngelCastilloB AngelCastilloB Awaiting requested review from AngelCastilloB

@rhyslbw rhyslbw Awaiting requested review from rhyslbw

Assignees

@mirceahasegan mirceahasegan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirceahasegan @iccicci @mkazlauskas