Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add explicit handle validation arg #1091

Merged
merged 2 commits into from
Feb 12, 2024
Merged

feat: add explicit handle validation arg #1091

merged 2 commits into from
Feb 12, 2024

Conversation

mkazlauskas
Copy link
Member

@mkazlauskas mkazlauskas commented Feb 12, 2024 •
edited
Loading

Context

Handle validation on submit is nice to have, but it should not prevent submitting transactions when it's not possible to do the validation (e.g. due to a bug, handle provider outage, or just not having a handle provider available).

Proposed Solution

Make handle validation an opt-in feature, so it is now possible to start a tx-submit provider without it.

Important Changes Introduced

@mkazlauskas
feat(ogmios): bypass handle validation when no handle provider is set
06d41c6
@mkazlauskas
feat(cardano-services): add an explicit option for tx-submit provider…
01938a2 
… handle validation

Handle validation on submit is nice to have, but it should not prevent
submitting transactions when it's not possible to do the validation
(e.g. due to a bug, or handle provider outage).

This commit makes handle validation an opt-in feature, so it is now
possible to start a tx-submit provider without it.
@github-actions GitHub Actions
Copy link

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-12 08:43:25.836557724 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-12 08:43:25.836557724 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "5"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 5
+  generation: 6
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zwhmys6v7kcvgqgbfd4wmf695aziprw3
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:dqk9gi1zdrd7kch45z7mkwr42f093x7b
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-12 08:43:25.956558504 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-12 08:43:25.956558504 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 08:43:26.076559281 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 08:43:26.076559281 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-12 08:43:26.200560087 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-12 08:43:26.200560087 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "5"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 5
+  generation: 6
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zwhmys6v7kcvgqgbfd4wmf695aziprw3
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:dqk9gi1zdrd7kch45z7mkwr42f093x7b
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 08:43:26.324560892 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 08:43:26.324560892 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "5"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 5
+  generation: 6
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zwhmys6v7kcvgqgbfd4wmf695aziprw3
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:dqk9gi1zdrd7kch45z7mkwr42f093x7b
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-12 08:43:26.444561670 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-12 08:43:26.444561670 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "5"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 5
+  generation: 6
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zwhmys6v7kcvgqgbfd4wmf695aziprw3
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:dqk9gi1zdrd7kch45z7mkwr42f093x7b
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-12 08:43:26.568562475 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-12 08:43:26.568562475 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "5"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 5
+  generation: 6
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zwhmys6v7kcvgqgbfd4wmf695aziprw3
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:dqk9gi1zdrd7kch45z7mkwr42f093x7b
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2741224329/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 08:43:26.692563280 +0000
+++ /tmp/MERGED-4161974871/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 08:43:26.692563280 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "5"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 5
+  generation: 6
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zwhmys6v7kcvgqgbfd4wmf695aziprw3
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:dqk9gi1zdrd7kch45z7mkwr42f093x7b
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2741224329/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-4161974871/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2741224329/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-12 08:43:26.812564061 +0000
+++ /tmp/MERGED-4161974871/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-12 08:43:26.812564061 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2741224329/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-4161974871/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2741224329/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-12 08:43:26.932564840 +0000
+++ /tmp/MERGED-4161974871/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-12 08:43:26.932564840 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2741224329/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-4161974871/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2741224329/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-12 08:43:27.052565618 +0000
+++ /tmp/MERGED-4161974871/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-12 08:43:27.052565618 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2741224329/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4161974871/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2741224329/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-12 08:43:27.180566447 +0000
+++ /tmp/MERGED-4161974871/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-12 08:43:27.180566447 +0000
@@ -20,7 +20,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2741224329/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4161974871/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2741224329/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 08:43:27.356567591 +0000
+++ /tmp/MERGED-4161974871/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 08:43:27.356567591 +0000
@@ -0,0 +1,49 @@
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  annotations:
+    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"RedirectConfig":{"Port":"443","Protocol":"HTTPS","StatusCode":"HTTP_301"},"Type":"redirect"}'
+    alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:us-east-1:926093910549:certificate/f136a39b-3556-4ddf-85ac-ac5b7431dd34
+    alb.ingress.kubernetes.io/healthcheck-path: /health
+    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP":80},{"HTTPS":443}]'
+    alb.ingress.kubernetes.io/scheme: internet-facing
+    alb.ingress.kubernetes.io/target-type: ip
+    alb.ingress.kubernetes.io/wafv2-acl-arn: arn:aws:wafv2:us-east-1:926093910549:regional/webacl/rate-limit/d4216c0e-b464-4383-953f-3262f4cd3cb6
+    external-dns.alpha.kubernetes.io/aws-region: us-east-1
+    external-dns.alpha.kubernetes.io/set-identifier: us-east-1-dev-preview-proxy
+  creationTimestamp: "2024-02-12T08:43:27Z"
+  generation: 1
+  labels:
+    app: coingecko-proxy
+    app.kubernetes.io/managed-by: std-kubectl
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
+    network: preview
+    release: dev-preview-cardanojs
+  name: dev-preview-cardanojs-coingecko-proxy
+  namespace: dev-preview
+  uid: d3289f45-1075-451b-9eca-51cf8972f637
+spec:
+  ingressClassName: alb
+  rules:
+  - host: coingecko.dev-preview.lw.iog.io
+    http:
+      paths:
+      - backend:
+          service:
+            name: ssl-redirect
+            port:
+              name: use-annotation
+        path: /
+        pathType: Prefix
+      - backend:
+          service:
+            name: dev-preview-cardanojs-coingecko-proxy
+            port:
+              name: http
+        path: /
+        pathType: Prefix
+  tls:
+  - hosts:
+    - coingecko.dev-preview.lw.iog.io
+status:
+  loadBalancer: {}
diff -u -N /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-12 08:43:25.356554606 +0000
+++ /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-12 08:43:25.356554606 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 08:43:25.472555360 +0000
+++ /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-12 08:43:25.472555360 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 08:43:25.592556138 +0000
+++ /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-12 08:43:25.592556138 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2741224329/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 08:43:25.712556920 +0000
+++ /tmp/MERGED-4161974871/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-12 08:43:25.712556920 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 861273ae86428efe18a82be65d388351b1b55283
+    app.kubernetes.io/version: 25a08e3ed0ff3af5df6b5f0a1e6b913ecaed800e
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

VanessaPC
VanessaPC approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@VanessaPC VanessaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@mkazlauskas mkazlauskas merged commit 3564618 into master Feb 12, 2024
7 checks passed
@mkazlauskas mkazlauskas deleted the feat/explicit-handle-validation-arg branch February 12, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhyslbw rhyslbw rhyslbw approved these changes

@VanessaPC VanessaPC VanessaPC approved these changes

@gytis-ivaskevicius gytis-ivaskevicius gytis-ivaskevicius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkazlauskas @rhyslbw @VanessaPC @gytis-ivaskevicius