Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): transactionSummaryInspector now correctly accounts for transaction fees #1088

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(core): transactionSummaryInspector now correctly accounts for transaction fees #1088

merged 1 commit into from
Feb 7, 2024

Conversation

AngelCastilloB
Copy link
Member

Context

The TransactionSummaryInspector doesn't properly account for transaction fees and always displays them as unresolved balance.

Proposed Solution

Fix TransactionSummaryInspector to properly account for transaction fees

mkazlauskas
mkazlauskas approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🕵️

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-07 16:16:23.464990063 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-07 16:16:23.464990063 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "134"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 134
+  generation: 135
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:bsnlc392zki8p0hv7hcpbwjsd0mjzqv4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:24963hlc65c9vjvjmf557qz9fkgdi6rv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-07 16:16:23.708989607 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-07 16:16:23.708989607 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 16:16:23.944989161 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 16:16:23.944989161 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-07 16:16:24.200988683 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-07 16:16:24.200988683 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "134"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 134
+  generation: 135
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:bsnlc392zki8p0hv7hcpbwjsd0mjzqv4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:24963hlc65c9vjvjmf557qz9fkgdi6rv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 16:16:24.436988239 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 16:16:24.436988239 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "101"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 101
+  generation: 102
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:bsnlc392zki8p0hv7hcpbwjsd0mjzqv4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:24963hlc65c9vjvjmf557qz9fkgdi6rv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-07 16:16:24.696987793 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-07 16:16:24.696987793 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "29"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 29
+  generation: 30
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:bsnlc392zki8p0hv7hcpbwjsd0mjzqv4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:24963hlc65c9vjvjmf557qz9fkgdi6rv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-07 16:16:24.936987535 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-07 16:16:24.936987535 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "29"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 29
+  generation: 30
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:bsnlc392zki8p0hv7hcpbwjsd0mjzqv4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:24963hlc65c9vjvjmf557qz9fkgdi6rv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2896027343/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 16:16:25.192987258 +0000
+++ /tmp/MERGED-627760814/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 16:16:25.192987258 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "30"
   creationTimestamp: "2024-01-10T17:49:47Z"
-  generation: 30
+  generation: 31
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:bsnlc392zki8p0hv7hcpbwjsd0mjzqv4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:24963hlc65c9vjvjmf557qz9fkgdi6rv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2896027343/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-627760814/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2896027343/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-07 16:16:25.428987005 +0000
+++ /tmp/MERGED-627760814/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-07 16:16:25.428987005 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2896027343/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-627760814/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2896027343/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-07 16:16:25.664986752 +0000
+++ /tmp/MERGED-627760814/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-07 16:16:25.664986752 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2896027343/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-627760814/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2896027343/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-07 16:16:25.916986477 +0000
+++ /tmp/MERGED-627760814/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-07 16:16:25.916986477 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2896027343/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-627760814/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2896027343/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-07 16:16:26.196986181 +0000
+++ /tmp/MERGED-627760814/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-07 16:16:26.196986181 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2896027343/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-627760814/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2896027343/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 16:16:26.448985907 +0000
+++ /tmp/MERGED-627760814/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 16:16:26.448985907 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-07 16:16:22.224992386 +0000
+++ /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-07 16:16:22.224992386 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 16:16:22.524991824 +0000
+++ /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 16:16:22.524991824 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 16:16:22.992990946 +0000
+++ /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 16:16:22.992990946 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2896027343/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 16:16:23.228990507 +0000
+++ /tmp/MERGED-627760814/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 16:16:23.228990507 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: acb62c3adb95dce4928a855729705c2496714e3d
+    app.kubernetes.io/version: 73988d16894d0ad4a475277c40de09e0fa60612f
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

@AngelCastilloB AngelCastilloB merged commit 6eb7c78 into master Feb 7, 2024
8 checks passed
@AngelCastilloB AngelCastilloB deleted the fix/lw-9749-transactionSummaryInspector-detects-incorrectly-fees-as-unaccounted-balance branch February 7, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@VanessaPC VanessaPC VanessaPC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AngelCastilloB @mkazlauskas @VanessaPC