Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(key-management): add payload to SignDataContext when signing cip8 structure #1087

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat(key-management): add payload to SignDataContext when signing cip8 structure #1087

merged 1 commit into from
Feb 7, 2024

Conversation

mkazlauskas
Copy link
Member

Context

The blob that's being signed wraps the payload

Proposed Solution

Adding the actual payload to context makes it easier to display it to the signer

Important Changes Introduced

@mkazlauskas mkazlauskas requested a review from a team February 7, 2024 07:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-07 08:32:17.094552052 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-07 08:32:17.094552052 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "132"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 132
+  generation: 133
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rzszqfc7zjrwr2wf12yxgh9cp644l3d2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:d8gyksc0a77gg1099ksl8k8x9pv9p2dv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-07 08:32:17.430551581 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-07 08:32:17.430551581 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 08:32:17.770551104 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 08:32:17.770551104 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-07 08:32:18.102550641 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-07 08:32:18.102550641 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "132"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 132
+  generation: 133
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rzszqfc7zjrwr2wf12yxgh9cp644l3d2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:d8gyksc0a77gg1099ksl8k8x9pv9p2dv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 08:32:18.446550159 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 08:32:18.446550159 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "99"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 99
+  generation: 100
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rzszqfc7zjrwr2wf12yxgh9cp644l3d2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:d8gyksc0a77gg1099ksl8k8x9pv9p2dv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-07 08:32:18.778549691 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-07 08:32:18.782549686 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "27"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 27
+  generation: 28
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rzszqfc7zjrwr2wf12yxgh9cp644l3d2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:d8gyksc0a77gg1099ksl8k8x9pv9p2dv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-07 08:32:19.118549215 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-07 08:32:19.118549215 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "27"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 27
+  generation: 28
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rzszqfc7zjrwr2wf12yxgh9cp644l3d2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:d8gyksc0a77gg1099ksl8k8x9pv9p2dv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1641958821/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 08:32:19.450548751 +0000
+++ /tmp/MERGED-2230473490/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 08:32:19.450548751 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "28"
   creationTimestamp: "2024-01-10T17:49:47Z"
-  generation: 28
+  generation: 29
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rzszqfc7zjrwr2wf12yxgh9cp644l3d2
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:d8gyksc0a77gg1099ksl8k8x9pv9p2dv
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1641958821/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-2230473490/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-1641958821/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-07 08:32:19.782548287 +0000
+++ /tmp/MERGED-2230473490/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-07 08:32:19.782548287 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1641958821/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-2230473490/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-1641958821/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-07 08:32:20.126547806 +0000
+++ /tmp/MERGED-2230473490/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-07 08:32:20.126547806 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1641958821/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-2230473490/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-1641958821/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-07 08:32:20.454547341 +0000
+++ /tmp/MERGED-2230473490/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-07 08:32:20.454547341 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1641958821/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2230473490/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1641958821/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-07 08:32:20.798546859 +0000
+++ /tmp/MERGED-2230473490/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-07 08:32:20.802546854 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1641958821/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2230473490/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1641958821/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 08:32:21.138546382 +0000
+++ /tmp/MERGED-2230473490/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 08:32:21.138546382 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-07 08:32:15.562554172 +0000
+++ /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-07 08:32:15.562554172 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 08:32:15.898553708 +0000
+++ /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-07 08:32:15.898553708 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 08:32:16.366553059 +0000
+++ /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-07 08:32:16.366553059 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1641958821/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 08:32:16.758552516 +0000
+++ /tmp/MERGED-2230473490/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-07 08:32:16.758552516 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: bbc894cb14ea2712024ff17aa75b5ca240f647a2
+    app.kubernetes.io/version: a45b2f42e38812bd2a520a3860726e591dfb7b3a
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

iccicci
iccicci previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkazlauskas mkazlauskas requested a review from a team February 7, 2024 08:13
ginnun
ginnun previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@ginnun ginnun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love tiny PRs!

@mkazlauskas
feat(key-management): add payload to SignDataContext when signing cip…
17a82b5 
…8 structure

the blob that's being signed wraps the payload

adding it to context makes it easier to display the actual data
@mkazlauskas mkazlauskas dismissed stale reviews from ginnun and iccicci via 17a82b5 February 7, 2024 08:19
@mkazlauskas mkazlauskas force-pushed the feat/sign-data-payload branch from 6777703 to 17a82b5 Compare February 7, 2024 08:19
mirceahasegan
mirceahasegan approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mkazlauskas ! 🚀

@mkazlauskas mkazlauskas merged commit acb62c3 into master Feb 7, 2024
8 checks passed
@mkazlauskas mkazlauskas deleted the feat/sign-data-payload branch February 7, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ginnun ginnun ginnun approved these changes

@iccicci iccicci iccicci approved these changes

@mirceahasegan mirceahasegan mirceahasegan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkazlauskas @ginnun @iccicci @mirceahasegan