Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cardano-services): un-skip previously skipped unit tests #1086

Merged
merged 1 commit into from
Feb 6, 2024
Merged

chore(cardano-services): un-skip previously skipped unit tests #1086

merged 1 commit into from
Feb 6, 2024

Conversation

iccicci
Copy link
Contributor

@iccicci iccicci commented Feb 6, 2024

Context

Fixtures generated with current cardano stack versions no longer causes problems.

Proposed Solution

Un-skipped a couple of tests skipped in the past as a quick workaround.

mirceahasegan
mirceahasegan approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-06 15:19:09.093948003 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-06 15:19:09.093948003 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "131"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 131
+  generation: 132
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:gpz14qah1wjslqwhzkblxrg77pq5ch0v
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-06 15:19:09.425944764 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-06 15:19:09.429944724 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 15:19:09.761941484 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 15:19:09.761941484 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-06 15:19:10.097938205 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-06 15:19:10.097938205 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "131"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 131
+  generation: 132
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:gpz14qah1wjslqwhzkblxrg77pq5ch0v
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 15:19:10.433934929 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 15:19:10.433934929 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "98"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 98
+  generation: 99
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:gpz14qah1wjslqwhzkblxrg77pq5ch0v
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-06 15:19:10.777931569 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-06 15:19:10.777931569 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "26"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 26
+  generation: 27
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:gpz14qah1wjslqwhzkblxrg77pq5ch0v
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-06 15:19:11.113928301 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-06 15:19:11.117928262 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "26"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 26
+  generation: 27
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:gpz14qah1wjslqwhzkblxrg77pq5ch0v
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-503849852/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 15:19:11.449925025 +0000
+++ /tmp/MERGED-3210316440/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 15:19:11.449925025 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "27"
   creationTimestamp: "2024-01-10T17:49:47Z"
-  generation: 27
+  generation: 28
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:gpz14qah1wjslqwhzkblxrg77pq5ch0v
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-503849852/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-3210316440/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-503849852/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-06 15:19:11.785921765 +0000
+++ /tmp/MERGED-3210316440/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-06 15:19:11.785921765 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-503849852/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-3210316440/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-503849852/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-06 15:19:12.117918529 +0000
+++ /tmp/MERGED-3210316440/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-06 15:19:12.117918529 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-503849852/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-3210316440/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-503849852/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-06 15:19:12.457915230 +0000
+++ /tmp/MERGED-3210316440/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-06 15:19:12.457915230 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-503849852/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3210316440/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-503849852/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-06 15:19:12.805911841 +0000
+++ /tmp/MERGED-3210316440/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-06 15:19:12.805911841 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-503849852/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3210316440/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-503849852/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 15:19:13.141908570 +0000
+++ /tmp/MERGED-3210316440/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 15:19:13.141908570 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-06 15:19:07.761961001 +0000
+++ /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-06 15:19:07.761961001 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 15:19:08.093957761 +0000
+++ /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 15:19:08.093957761 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 15:19:08.425954527 +0000
+++ /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 15:19:08.425954527 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-503849852/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 15:19:08.757951282 +0000
+++ /tmp/MERGED-3210316440/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 15:19:08.757951282 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 632bf525e2ade43c47d0ce526acc348be4e79b81
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

@iccicci iccicci merged commit b64446c into conway-era Feb 6, 2024
8 checks passed
@iccicci iccicci deleted the chore/LW-9184-un_skip-tests branch February 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mirceahasegan mirceahasegan mirceahasegan approved these changes

@rhyslbw rhyslbw Awaiting requested review from rhyslbw

@mchappell mchappell Awaiting requested review from mchappell

@pczeglik-iohk pczeglik-iohk Awaiting requested review from pczeglik-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iccicci @mkazlauskas @mirceahasegan