Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master #1085

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Merge master #1085

merged 12 commits into from
Feb 6, 2024

Conversation

iccicci
Copy link
Contributor

@iccicci iccicci commented Feb 6, 2024

Context

Merging master into conway-era.

Important Changes Introduced

Skipped a unit test about collaterals as it requires scripts, currently not supported by cardano-node (no valid txs are present in the fixtures).

renanvalentin and others added 12 commits February 1, 2024 14:12
@renanvalentin
feat(cardano-services): resolve collateralReturn property
98291b5
@renanvalentin
refactor(cardano-services): rename query name to prevent naming colli…
983495e 
…sion when collateral is set to true
@renanvalentin
fix(cardano-services): change log pattern match
d1286b7
@AngelCastilloB
feat(core)!: tokenTransferInspector and txSummaryInspector now return…
219623f 
… AssetInfo rather than AssettId

BREAKING CHANGE: tokenTransferInspector now takes an extra parameter AssetProvider
- txSummaryInspector now takes an extra parameter AssetProvider
- tokenTransferInspector now return AssetInfo rather than AssettId
- txSummaryInspector now return AssetInfo rather than AssettId
@mkazlauskas
Merge pull request #1076 from input-output-hk/feat/lw-9670-txSummaryI…
3074d53 
…nspector-and-tokenTransferInspector-must-return-assetinfo

Feat/lw 9670 tx summary inspector and token transfer inspector must return assetinfo
@lace-bot
ci: publish packages [skip actions]
dff9dcf 
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
@mkazlauskas
fix(web-extension): delete active wallet from storage and emit null o…
64bf9c0 
…n deactivate

when wallet manager is reinitialized, it would try to activate a wallet that was deactivated

when wallet is deactivated, it should emit null to indicate there's no active wallet
@mkazlauskas
Merge pull request #1083 from input-output-hk/fix/wallet-manager-deac…
35845b5 
…tivate-emit-persist

fix(web-extension): delete active wallet from storage and emit null
@lace-bot
ci: publish packages [skip actions]
170253c 
 - @cardano-sdk/[email protected]
 - @cardano-sdk/[email protected]
@renanvalentin
Merge pull request #1077 from input-output-hk/feat/lw-9678-resolve-co…
2cd1e01 
…llateral-return-property

feat(cardano-services): resolve collateralReturn property
@iccicci
Merge branch 'master' into merge-master
d464498
@iccicci
test(cardano-services): skipped test about collaterals as it requires…
622c3cc 
… scripts
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-06 10:38:16.827854444 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-06 10:38:16.827854444 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "131"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 131
+  generation: 132
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:y5zrdppy9m17yxi9karsd1ffivy04f3q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-06 10:38:17.027853724 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-06 10:38:17.031853710 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 10:38:17.227853002 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 10:38:17.231852988 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-06 10:38:17.431852269 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-06 10:38:17.431852269 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "131"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 131
+  generation: 132
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:y5zrdppy9m17yxi9karsd1ffivy04f3q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 10:38:17.631851550 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 10:38:17.635851536 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "98"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 98
+  generation: 99
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:y5zrdppy9m17yxi9karsd1ffivy04f3q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-06 10:38:17.835850816 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-06 10:38:17.839850802 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "26"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 26
+  generation: 27
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:y5zrdppy9m17yxi9karsd1ffivy04f3q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-06 10:38:18.043850069 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-06 10:38:18.043850069 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "26"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 26
+  generation: 27
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:y5zrdppy9m17yxi9karsd1ffivy04f3q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1277567849/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 10:38:18.247849334 +0000
+++ /tmp/MERGED-1849086199/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 10:38:18.247849334 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "27"
   creationTimestamp: "2024-01-10T17:49:47Z"
-  generation: 27
+  generation: 28
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:y5zrdppy9m17yxi9karsd1ffivy04f3q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1277567849/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-1849086199/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-1277567849/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-06 10:38:18.447848617 +0000
+++ /tmp/MERGED-1849086199/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-06 10:38:18.447848617 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1277567849/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-1849086199/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-1277567849/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-06 10:38:18.647847894 +0000
+++ /tmp/MERGED-1849086199/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-06 10:38:18.647847894 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1277567849/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-1849086199/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-1277567849/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-06 10:38:18.847847177 +0000
+++ /tmp/MERGED-1849086199/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-06 10:38:18.847847177 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1277567849/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1849086199/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1277567849/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-06 10:38:19.055846428 +0000
+++ /tmp/MERGED-1849086199/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-06 10:38:19.055846428 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1277567849/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1849086199/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1277567849/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 10:38:19.255845717 +0000
+++ /tmp/MERGED-1849086199/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 10:38:19.255845717 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-06 10:38:16.015857365 +0000
+++ /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-06 10:38:16.015857365 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 10:38:16.219856633 +0000
+++ /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 10:38:16.219856633 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 10:38:16.419855909 +0000
+++ /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 10:38:16.419855909 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1277567849/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 10:38:16.623855179 +0000
+++ /tmp/MERGED-1849086199/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 10:38:16.623855179 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: 58b04aa3ec2cb3e861bffe258626b9a44a47bb83
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

mirceahasegan
mirceahasegan approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iccicci iccicci merged commit 7fbcc0f into conway-era Feb 6, 2024
8 checks passed
@iccicci iccicci deleted the merge-master branch February 6, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceahasegan mirceahasegan mirceahasegan approved these changes

@rhyslbw rhyslbw Awaiting requested review from rhyslbw

@mkazlauskas mkazlauskas Awaiting requested review from mkazlauskas

@mchappell mchappell Awaiting requested review from mchappell

@pczeglik-iohk pczeglik-iohk Awaiting requested review from pczeglik-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iccicci @mirceahasegan @renanvalentin @AngelCastilloB @mkazlauskas @lace-bot