Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): added a new input resolver decorator that also fetches from the backend #1082

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat(wallet): added a new input resolver decorator that also fetches from the backend #1082

merged 2 commits into from
Feb 6, 2024

Conversation

AngelCastilloB
Copy link
Member

Context

In order to inspect the transaction that’s build by the dapp, input resolver that we have in WalletUtil is not going to work because it only resolves own addresses.

Create a new input resolver that utilizes the existing one and queries chain history provider for inputs that are not resolved as own

Proposed Solution

Add a decorator to the inputResolver that additional resolve inputs from the backend if the inputs are not found in our UTXO set.

@AngelCastilloB
Copy link
Member Author

AngelCastilloB commented Feb 2, 2024 •
edited
Loading

@mkazlauskas I also added an optional parameters that allow us to pass an array of local transaction to the input resolver, if given these will be used before fetching from the backend. I am thinking this could be useful for transaction chaining in the future (or to have the resolver look into any transaction not yet on chain)

@AngelCastilloB AngelCastilloB requested a review from a team February 2, 2024 18:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-06 13:20:22.414057871 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-06 13:20:22.414057871 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "131"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 131
+  generation: 132
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:njrnbz1p86qslif0n1nw2dgi14r8kyrc
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-06 13:20:22.726056924 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-06 13:20:22.726056924 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 13:20:22.930056302 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 13:20:22.930056302 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-06 13:20:23.138055904 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-06 13:20:23.138055904 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "131"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 131
+  generation: 132
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:njrnbz1p86qslif0n1nw2dgi14r8kyrc
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 13:20:23.338055799 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 13:20:23.338055799 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "98"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 98
+  generation: 99
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:njrnbz1p86qslif0n1nw2dgi14r8kyrc
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-06 13:20:23.546055689 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-06 13:20:23.546055689 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "26"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 26
+  generation: 27
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:njrnbz1p86qslif0n1nw2dgi14r8kyrc
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-06 13:20:23.750055582 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-06 13:20:23.750055582 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "26"
   creationTimestamp: "2024-01-11T10:37:15Z"
-  generation: 26
+  generation: 27
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:njrnbz1p86qslif0n1nw2dgi14r8kyrc
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-4227263674/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 13:20:23.954055475 +0000
+++ /tmp/MERGED-4058748894/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 13:20:23.954055475 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "27"
   creationTimestamp: "2024-01-10T17:49:47Z"
-  generation: 27
+  generation: 28
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:w6xlwsmh9rxv6pg9ixa45whcgzbdwjc4
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:njrnbz1p86qslif0n1nw2dgi14r8kyrc
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-4227263674/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-4058748894/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-4227263674/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-06 13:20:24.158055369 +0000
+++ /tmp/MERGED-4058748894/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-06 13:20:24.158055369 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-4227263674/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-4058748894/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-4227263674/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-06 13:20:24.366055258 +0000
+++ /tmp/MERGED-4058748894/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-06 13:20:24.366055258 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-4227263674/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-4058748894/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-4227263674/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-06 13:20:24.570055151 +0000
+++ /tmp/MERGED-4058748894/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-06 13:20:24.570055151 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-4227263674/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4058748894/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-4227263674/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-06 13:20:24.790055036 +0000
+++ /tmp/MERGED-4058748894/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-06 13:20:24.790055036 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-4227263674/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4058748894/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-4227263674/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 13:20:24.994054927 +0000
+++ /tmp/MERGED-4058748894/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 13:20:24.994054927 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-06 13:20:21.606060334 +0000
+++ /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-06 13:20:21.606060334 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 13:20:21.806059726 +0000
+++ /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-06 13:20:21.806059726 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 13:20:22.006059116 +0000
+++ /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-06 13:20:22.006059116 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-4227263674/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 13:20:22.210058497 +0000
+++ /tmp/MERGED-4058748894/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-06 13:20:22.210058497 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2cd1e0159e4b3da99c3df60890970d8af304b0fe
+    app.kubernetes.io/version: daf0cfc3906815fbe2aeaf8afdea915086113d88
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

DominikGuzei
DominikGuzei previously approved these changes Feb 5, 2024
View reviewed changes
@AngelCastilloB AngelCastilloB force-pushed the feat/lw-9629-create-inputresolver-that-can-resolve-both-own-and-foreign-inputs branch from 9f808ac to 2413c10 Compare February 5, 2024 17:40
mkazlauskas
mkazlauskas approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@AngelCastilloB
feat(wallet): added a new input resolver that fetches from the backend
c831857
@AngelCastilloB
feat!: inputResolver resolveInput function now takes an additional pa…
14c486d 
…rameter options

BREAKING CHANGE: inputResolver resolveInput function now takes an additional parameter options
@AngelCastilloB AngelCastilloB force-pushed the feat/lw-9629-create-inputresolver-that-can-resolve-both-own-and-foreign-inputs branch from 2413c10 to 14c486d Compare February 6, 2024 13:13
mirceahasegan
mirceahasegan approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @AngelCastilloB 🥇

@AngelCastilloB AngelCastilloB merged commit bbc894c into master Feb 6, 2024
8 checks passed
@AngelCastilloB AngelCastilloB deleted the feat/lw-9629-create-inputresolver-that-can-resolve-both-own-and-foreign-inputs branch February 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mirceahasegan mirceahasegan mirceahasegan approved these changes

@pczeglik-iohk pczeglik-iohk pczeglik-iohk approved these changes

@DominikGuzei DominikGuzei DominikGuzei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AngelCastilloB @DominikGuzei @mkazlauskas @mirceahasegan @pczeglik-iohk