Skip to content

Conversation

@Lennart01
Copy link
Member

Description

Changelog

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually a proponent of splitting stuff into multiple files, however I'm not sure in this case because it adds another file to the project root. Could you add in into the main file or if you want to split it maybe add a subdirectory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id argue this is fine.
Only one file

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Oct 7, 2024
@Lennart01 Lennart01 requested a review from Copilot May 27, 2025 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR to enhance nginx configuration with additional security headers and improve caching headers.

  • Added multiple security headers: X-XSS-Protection, X-Content-Type-Options, Referrer-Policy, Content-Security-Policy, Permissions-Policy, X-Frame-Options, and Expect-CT.
  • Updated the Cache-Control header for selected media files to include the "must-revalidate" directive.

@octomind-dev

This comment has been minimized.

@github-actions
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4397.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-fec2de7

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-fec2de7

@octomind-dev
Copy link

octomind-dev bot commented May 28, 2025

🐙 Octomind

Test Report: 14/14 successful.

description status details
test all ways to open the setup flow Passed ✅ click
sign-in Passed ✅ click
share_session Passed ✅ click
get started Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
create lean coffee board Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create and delete board columns Passed ✅ click
close cookie banner - sign-in Passed ✅ click
close cookie banner - front page Passed ✅ click
check terms & conditions Passed ✅ click
check Privacy Policy Passed ✅ click
change avatar Passed ✅ click
About Section Visibility Test Passed ✅ click

commit sha: fec2de7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Requested Changes requested by the reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants