-
Notifications
You must be signed in to change notification settings - Fork 68
feat: nginx sec headers #4397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: nginx sec headers #4397
Conversation
Signed-off-by: Lennart Krauch <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm usually a proponent of splitting stuff into multiple files, however I'm not sure in this case because it adds another file to the project root. Could you add in into the main file or if you want to split it maybe add a subdirectory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id argue this is fine.
Only one file
Signed-off-by: Lennart Krauch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A PR to enhance nginx configuration with additional security headers and improve caching headers.
- Added multiple security headers: X-XSS-Protection, X-Content-Type-Options, Referrer-Policy, Content-Security-Policy, Permissions-Policy, X-Frame-Options, and Expect-CT.
- Updated the Cache-Control header for selected media files to include the "must-revalidate" directive.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Lennart Krauch <[email protected]>
|
The deployment to the dev cluster was successful. You can find the deployment here: https://4397.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 14/14 successful.
commit sha: fec2de7 |
Description
Changelog
Checklist
(Optional) Visual Changes