Skip to content

KV interface for stored Evaluables in aggregate engines #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyhb merged 4 commits into from
Apr 29, 2025
Merged

KV interface for stored Evaluables in aggregate engines #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5cf506
Vendor
tonyhb Apr 29, 2025
a85169a
Add base eval KV storage
tonyhb Apr 29, 2025
03ec935
Fix tests using a concrete type for evaluator
tonyhb Apr 29, 2025
fbc776f
Remove parsed link from expression part
tonyhb Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 8 additions & 2 deletions engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"

"github.com/cespare/xxhash/v2"
"github.com/google/uuid"
)

type EngineType int
Expand Down Expand Up @@ -100,9 +101,14 @@ func (p ExpressionPart) Equals(n ExpressionPart) bool {
}

func (p ExpressionPart) ToStored() *StoredExpressionPart {
var id uuid.UUID
if p.Parsed != nil {
id = p.Parsed.EvaluableID
}

return &StoredExpressionPart{
EvaluableID: id,
GroupID: p.GroupID,
Parsed: p.Parsed,
PredicateID: p.Hash(),
Ident: &p.Predicate.Ident,
}
Expand All @@ -111,8 +117,8 @@ func (p ExpressionPart) ToStored() *StoredExpressionPart {
// StoredExpressionPart is a lightweight expression part which only stores
// a hash of the predicate to reduce memory usage.
type StoredExpressionPart struct {
EvaluableID uuid.UUID
GroupID groupID
PredicateID uint64
Parsed *ParsedExpression
Ident *string
}
Loading