fix: wrap finalize block to recover panic

[beer-1]

Description

cosmos/cosmos-sdk#24005

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:

• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling during block processing, ensuring that unexpected issues are gracefully managed, thereby enhancing application stability.

• Chores

  • Upgraded a core dependency to its latest stable version, incorporating minor improvements and fixes for better performance.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new FinalizeBlock method in the MinitiaApp struct (in app/app.go) that wraps the block finalization process with a deferred recovery function. This ensures that panics during block finalization are caught and transformed into formatted errors instead of crashing the system. Additionally, the version of the github.com/cosmos/cosmos-sdk dependency has been updated in both the project’s main go.mod and the integration-tests/go.mod files from v0.50.12 to v0.50.13.

Changes

File(s)	Change Summary
app/app.go	Added a new FinalizeBlock method to MinitiaApp that includes deferred recovery from panics and calls the original BaseApp implementation.
go.mod, integration-tests/go.mod	Updated the github.com/cosmos/cosmos-sdk dependency version from v0.50.12 to v0.50.13.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client/Node
    participant A as MinitiaApp
    participant B as BaseApp

    C->>A: Send FinalizeBlock request
    A->>A: Setup deferred recovery
    A->>B: Call original FinalizeBlock
    B-->>A: Return block finalization result
    A->>C: Return result or error if panic occurred

Loading

Possibly related PRs

• fix: audit #71: Contains changes to the MinitiaApp struct, including the addition of the setPostHandler method, which relates code-level modifications alongside the new FinalizeBlock implementation.

Suggested reviewers

• djm07073

Poem

In the code garden, I bounce with cheer,
A new block finalization method is here!
I catch the panics with a gentle paw,
Keeping crashes away without a flaw.
Dependencies bloom, refreshed and bright—
Hoppin’ through changes with delight! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package injective: could not load export data: no export data for "github.com/cosmos/relayer/v2/relayer/codecs/injective""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package injective: could not load export data: no export data for "github.com/cosmos/relayer/v2/relayer/codecs/injective""

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dea56de and 19d2e08.

⛔ Files ignored due to path filters (2)

• go.sum is excluded by !**/*.sum
• integration-tests/go.sum is excluded by !**/*.sum

📒 Files selected for processing (3)

• app/app.go (1 hunks)
• go.mod (1 hunks)
• integration-tests/go.mod (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.