fix(sim): Make simulation process actually continuous #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Evalir
commented
Jul 4, 2025
Evalir
force-pushed
the
evalir/make-sim-continous
branch
2 times, most recently
from
62da5ad to
dbfc062
Compare
prestwich
reviewed
Jul 7, 2025
Right now, the simulator stops as soon as there are no more items to simulate. This actually is not correct behavior, as we could be early in the slot, with more items coming in later in the slot which could yield a higher total payout on the block. What we actually want, is to simply skip doing the round at all if there are no items, sleep for a certain amount of time (bounded by the deadline), and either break (if we slept until the deadline) or continue if there's still time remaining. The resulting behavior is that the simulator always runs until the deadline, ensuring that items that come later in the slot, up until the deadline, can be simulated and included in the block.
Evalir
changed the base branch from
evalir/correct-ru-orders-address
to
graphite-base/86
Evalir
force-pushed
the
evalir/make-sim-continous
branch
from
dbfc062 to
00c4075
Compare
prestwich
requested changes
Jul 7, 2025
prestwich
reviewed
Jul 8, 2025
| use tracing::{debug, info_span, trace, Instrument}; | ||
| use trevm::{ | ||
| helpers::Ctx, | ||
| revm::{inspector::NoOpInspector, DatabaseRef, Inspector}, | ||
| Block, Cfg, | ||
| }; | ||
|
|
||
| /// The amount of time to sleep between simulation rounds when there are no items to simulate. | ||
| pub(crate) const SIM_SLEEP_MS: u64 = 50; |
There was a problem hiding this comment.
future idea: make the sim-cache return a future that resolves when it has more items to sim
prestwich
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(sim): Make simulation process actually continuous
Right now, the simulator stops as soon as there are no more items to simulate. This actually is not correct behavior, as we could be early in the slot, with more items coming in later in the slot which could yield a higher total payout on the block.
What we actually want, is to simply skip doing the round at all if there are no items, sleep for a certain amount of time (bounded by the deadline), and either break (if we slept until the deadline) or continue if there's still time remaining.
The resulting behavior is that the simulator always runs until the deadline, ensuring that items that come later in the slot, up until the deadline, can be simulated and included in the block.
chore: properly break if we sleep until deadline