breaking up simulator code #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
changed the base branch from
main
to
03-16-adds_simulation_factory_to_builder
Evalir
reviewed
Apr 9, 2025
dylanlott
reviewed
Apr 9, 2025
src/tasks/sim/factory.rs
Outdated
| Db: DatabaseRef + Clone + Sync, | ||
| Insp: Sync, | ||
| { | ||
| type Database = CacheOnWrite<Db>; |
There was a problem hiding this comment.
Why the change from Arc<ConcurrentState> to only CacheOnWrite?
| } | ||
|
|
||
| impl<In, Out, S> SimOutcome<In, Out, S> { | ||
| /// Creates a new `Best` instance. |
There was a problem hiding this comment.
nit: update comments which still call this Best
| for handle in handles { | ||
| let result = handle.join().unwrap(); | ||
| if let Some(candidate) = result { | ||
| if *candidate.score() > best_score { |
There was a problem hiding this comment.
note: if the scores for all transactions are zero then best will remain None
(this might be what we want the behavior to be, or we might prefer that it returns one of the transactions?)
|
closing in favor of sdk work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #63