Skip to content

Conversation

@svenrdz
Copy link

@svenrdz svenrdz commented Dec 18, 2020

Made this little change on my local fork, as I wanted to define a triple quote string and couldn't.

The current behaviour looks like this:

nim> var s = """
Error: closing """ expected, but end of file reached

Little drawback with this change, the closing triple quote also counts as a trigger.

Also it still won't indent if there is any text after the opening triple quote, but that would require a bit of change in the way indent triggers are checked for.

@0atman
Copy link
Collaborator

0atman commented Mar 18, 2021

Nice! Thank you for this, I wonder if it's possible to fix those problems?
I'm somewhat in two minds about the amount of new functionality vs weird functionality this PR brings, and perhaps it's less surprising to hold off merging this for now?

@0atman 0atman added help wanted Extra attention is needed question Further information is requested labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants