Thunderbird 68 compatibility #11
Conversation
Instead of providing our own page for selecting between local normal and local address book calendars, we now just add the address book option directly to the inital page. This reduces the complexity and works around a bug where the content of our overlay wizard page is not properly displayed. We now also disable address books in the selection, for which there already is an calendar, where we would previously silently fail.
When multiple extensions add an entry to the calendar-type radiogroup, we have to be careful with handling the status of the advance button, which is shared. To handle this, we use the fact that there are two events fired when the type is changed: select and command In the first event (select), we can update the button without caring about other extensions, while in the second one (command), we only update if we are currently selected. This allows resetting the state in the first event and giving another extension the control over the button in the second event.
|
I think this is ready for review @ingomueller-net. I am not sure about my last point on the todo list. I would remove the old manifest, as we are probably no longer compatible with old versions (I haven't checked and I don't intend to change that if we are not). The new manifest format is pretty limited compared to the old one, so most of the additional info should probably move to the Credits section in the README or maybe into a new CONTRIBUTORS file. |
|
Would it be possible for you to provide your current build for download @klemens? |
|
@Noctum28: Here you go: https://asa.crpt.de/files/thunderbirthday-0.8.4-tb68.xpi This version lacks the last commit and stays on the current version 0.8.4, to make sure you get any potential future update. |
|
Thank you @klemens! |
|
Looks very good! Thanks a lot for the work! I would be in favor of removing the old file. A CONTRIBUTORS (my small preference) or README file sound like a good idea. Am I right that a new string was added? I should thus ask for updates on Babelzilla as well, right? I guess it is best to release new version first and release minor versions as translations come in? |
|
I have removed the old manifest and added a CONTRIBUTORS file.
Yes, that would be great, here is a screen of how the string looks like in the application:
Yes, I think this would be best. |
Also update the links in the README.
|
Will there be a new version of Thunderbirthday? Do you @klemens will release a fork on https://addons.thunderbird.net/de/thunderbird/ Or is the only chance to use this:
|
|
Great. Finally one of the most important addon works again. Thank you very much! |
|
@ingomueller-net Would you mind merging this PR? TB68 is around for quite some time and it would be a shame if this extension wouldn't survive :/ Otherwise I'd ask @klemens to fork the extension. |
|
Hello everyone, @klemens patch is available for ~4 months now. What can we do to get the addon running again? Is there something me as fully unexperienced in TB can do? Thanks! |
|
They are saying that the author isn't responding, apparently having abandoned this project. Does that mean it's time for someone to fork the repository and take over the project? It would involved coordinating with Mozilla to have the add-on listed in the official Thunderbird add-ons repository. |
|
Thanks, @klemens, for providing thunderbirthday-0.8.4-tb68.xpi! It works |
|
Version 0.8.4-tb68 builds and works fine here ("opensuse tumbleweed 20191221", "ubuntu 19.10" and "ubuntu 18.04.3 LTS") with thunderbird 68.3.0. Is there only one developer with write access in this project? |
|
I would be willing to kick in some $ |
|
@ryanleesipes and @cleidigh : What was the forking-procedure again? I forgot. This is a working replacement for ThunderBirthDay and the original author @ingomueller-net is not responding. What can we do to get that onto ATN? Do we have this on our todo list already? Would @klemens be willing to continue to maintain the new version? |
|
@ingomueller-net : In case you do read this, would you allow us to add @klemens as a maintainer to your ThunderBirthDay add-on, so he can upload new versions? We always try to update existing add-ons instead of creating new ones, as it is the much better UX, as all current users will get the update automatically. |
|
Has anyone ever written to Ingo Müller directly? I think this is his website. |
|
I have emailed Ingo this moment. Which is another one; see next comment. |
|
Yes but it that was me. And I am the totally wrong person. :-) |
|
Ingo has commented in this issue (here), so he is reading this. |
|
I contacted him at his work address (mail).... hope this wasn't too intrusive... |
|
Hi all, after almost half a year without a response from Ingo, even contacting him directly, we probably should consider that there won't be an answer or even the "easy" solution of adding another maintainer to this project. |
|
So, I looked a bit into how we can continue this addon in thunderbird 78. The current plan seems to be to only support webextensions, so we basically have to rewrite the add-on. The good news is that the webextension api for the address book already looks very usable and would certainly work for our propose, however the calendar side of things is currently not so clear to me. The TB team is currently working on integrating Lightning directly into thunderbird, but I haven't seen anything about a proposed api yet. Though that doesn't mean we cannot use its apis directly, as thunderbird (in contrast to firefox) will still allow access to the core apis through experiments in release builds. If someone wants to help with this effort, feel free to contact me. I'll also setup a repo once I have anything usable. |
|
That is the correct strategy. I do think, that before the release of 78 there will be an official calendar API, but if you want to start hacking now, an experimental API is an alternative. A few pointers: https://github.com/cleidigh/EditEmailSubject-MX/tree/master/scripts/dev-tools/localization/dtd-converter-py If you create a new repo for this, please ping me. |
|
To get help on dev tasks, we list our communication channels here: A list of useful resources: |
|
I've just tried to install this and it seems to work just fine in TB 68.4.1. |
|
Works with TB 68.10.0.. thx to everyone putting in effort for v78! 🙌 |
|
This is exciting news. Could someone clarify where the new version will be released at? Thanks. |
|
@garretwilson misunderstanding: the version linked above works with v.68.10 |
|
Even a version that works with v68.x will help out for now. But I have the same question: will this version that works with Thunderbird 68.x be published on https://addons.thunderbird.net/ or some other official site? I don't know what https://asa.crpt.de/ is and I'm not a fan of installing extensions from random third-party sites. |
|
@garretwilson: No, I don't plan to release the TB68 version to ATN, using the build from my server (now available again…) or building yourself from this branch are your only options. But when (if) the new TB78 version will be available, then I will of course push it to ATN. |
|
@klemens: We are preparing a shortcut update guide: If you are interested and have any questions, we are available here: |
First of all, thank you so much for developing the add-on. I have come here through a search engine. I have tried to find the build you mentioned on your website but I couldn't. Is the build for TB 68 still available? |
Please, ignore me. For some reason I missed the link in the stream of comments. Installed and working, thank you! |
Good morning. Thunderbird 78.2.2 just arrived for me on the main release channel. Could this extension please be released on https://addons.thunderbird.net/ so that I can install it via official means? That would be very helpful. Thanks. |
|
@klemens: Thunderbird 78 has finally given up the old mab file format. Will Thunderbirthday be able to work with SQLite address book files in the future? Or uses Thunderbird internal functions to read address data? |
|
@klemens (and maybe other interested parties) I implemented a simple Birthday Calendar add-on as proof of concept for upcoming calendar APIs. I plan to release it on ATO eventually, but it is not yet sufficiently tested. If you (or somebody else) wants to contribute, I'm open to pull requests. |
|
@rsjtdrjgfuzkfg I'll test in the next days. I also use the "Provider for Google Calendar" and need some fixes, too. Really terrible since Thunderbird's version hop from 68 to 78... I still use version 68. Anyways, thanks for your effort so far! |
|
@rsjtdrjgfuzkfg |
|
@jf82491 It would probably be better to discuss feature ideas and concrete bugs regarding the new add-on in the new repository's issue tracker. But to answer your indirect question: displaying ages was already on my roadmap and is now ready for testing in version 0.2. |
|
Any News about a Version for Thunderbird 78.x? |
|
This thing here is dead. Use the new shiny WebExtension: |
|
Yes, I've changed to that one, too. |
This PR adds a json manifest for (only) Thunderbird 68 and reworks the calendar creation for work with the updated lightning (see commit message for details). It also bumps the version to the next mayor one as suggested by the TB 68 migration guide.
TODO