Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Release v0.14.7 #1528

Merged
merged 1 commit into from
Oct 8, 2024
Merged

VSCode Release v0.14.7 #1528

merged 1 commit into from
Oct 8, 2024

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented Oct 8, 2024

v0.14.7 -- 2024-10-08

Added

Changed

Deprecated

Removed

Fixed

Security

@bugarela bugarela merged commit 44f5251 into main Oct 8, 2024
14 checks passed
@bugarela bugarela deleted the vscode-release/0.14.7 branch October 8, 2024 13:37
@lucab
Copy link
Contributor

lucab commented Oct 10, 2024

First of all, thanks for the release!
I was looking into picking up the new version from the marketplace, but the latest version I can see there is 0.14.6: https://marketplace.visualstudio.com/items?itemName=informal.quint-vscode
Do you maybe still need to manually publish the latest release there?

@bugarela
Copy link
Collaborator Author

First of all, thanks for the release! I was looking into picking up the new version from the marketplace, but the latest version I can see there is 0.14.6: https://marketplace.visualstudio.com/items?itemName=informal.quint-vscode Do you maybe still need to manually publish the latest release there?

Yes! I was traveling and for some reason the command to push the release was not working on my laptop and I didn't find time to fix it. I'm now back home and will push this properly.

@bugarela
Copy link
Collaborator Author

Done: https://marketplace.visualstudio.com/items?itemName=informal.quint-vscode

@lucab
Copy link
Contributor

lucab commented Oct 16, 2024

Thanks!
I just noticed that this one is apparently lagging behind too: https://www.npmjs.com/package/@informalsystems/quint-language-server

@bugarela
Copy link
Collaborator Author

Right 🤦. Having this not automated is usually fine, but I guess it becomes a problem in non-ideal situations like this one 😅. Just pushed it, should be updated in npm in a few mins.

Thanks a lot for keeping an eye on this - you avoided potentially loads of confusion in the future.

@lucab
Copy link
Contributor

lucab commented Oct 17, 2024

I'm having some hard time understanding what's going on, but apparently the informal.quint-vscode-0.14.7 extension is somehow carrying an older version of @informalsystems/quint in its node_modules directory:

$ jq '.version' ${HOME}/.vscode/extensions/informal.quint-vscode-0.14.7/server/node_modules/@informalsystems/quint/package.json 

"0.22.1"

I initially thought there was something wrong in my local setup, but then I verified that this is actually coming from the .vsix bundle in the marketplace.
You can check it yourself by clicking on Download Extension in https://marketplace.visualstudio.com/items?itemName=informal.quint-vscode and then manually opening the zip archive.

@bugarela
Copy link
Collaborator Author

That's very weird! I believe there's a high chance that this is due to me preparing the release and then actually releasing from two different computers (I prepared it in my laptop, and pushed it (from the proper commit) from my home computer). Probably our script is not good enough to handle this scenario, and there are some missing commands that needed to be run (i.e. npm install from the release commit before pushing).

There's no way to change a release, but I'll cut a new version for VSCode tomorrow and open an issue to improve this setup. Again, thanks for checking and sorry for not testing this properly - it has been working fine until I did it a bit out of the ordinary way.

@bugarela bugarela mentioned this pull request Oct 18, 2024
@bugarela
Copy link
Collaborator Author

Ok, new version is out, I updated my extension from the marketplace and everything seems to work fine, finally!

image

I guess we need to add hashbang to the tmLanguage file so it gets properly highlighted in vscode (and also the other editors by updating their own syntax highlight config) - but that's a minor thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants